Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.2 translation update #2229

Merged
merged 1 commit into from
Aug 7, 2019
Merged

2.2.2 translation update #2229

merged 1 commit into from
Aug 7, 2019

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Aug 7, 2019

…ware/mixxxdj/mixxx2-2/. Compile QM files out of TS files that are used by the localized app

…ware/mixxxdj/mixxx2-2/. Compile QM files out of TS files that are used by the localized app
@daschuer daschuer mentioned this pull request Aug 7, 2019
14 tasks
@@ -10150,7 +10150,6 @@ Fully right: end of the effect period</source>
<message>
<location filename="../../src/skin/tooltips.cpp" line="344"/>
<source>Key</source>
<extracomment>The musical key of a track</extracomment>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an explanation why those <extracomment> fields for the musical key have disappeared?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. My first guess is that it is related to to to the transiflex tool version. But looking in to the file history, this 6 years old entry comes and goes in different commits, from me and others.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so let's just ignore it. We couldn't even do anything about it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. My first guess is that it is related to to to the transiflex tool version. But looking in to the file history, this 6 years old entry comes and goes in different commits, from me and others.

I do not think so. Transifex does not modify template file *.ts.
The comments are in the code , e.g. https://github.com/mixxxdj/mixxx/blob/2.2/src/skin/tooltips.cpp#L343

To me looks like it depends on the QT Linguist version used (when running lupdate & lrelease).

As a test, i did just run lupdate src -recursive -noobsolete -extensions cpp,h,ui -ts res/translations/mixxx.ts against the latest 2.2 tree, and the extracomments are back again.

$ lupdate -version
lupdate version 5.12.3

These comments were helpful, and in my opinion are still useful today to avoid misleading translations.

The deletion should be reverted.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed for lupdate version 5.12.4, the extracomments are back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...but I'm not able to push the changes to Transifex.

Copy link
Contributor

@esbrandt esbrandt Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...but I'm not able to push the changes to Transifex.

Please accept email invitation ( just send) and try again.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I'm still not able to push template updates:

tx push -s
tx INFO: Pushing resource mixxxdj.mixxx2-2
tx INFO: Pushing source file (res/translations/mixxx.ts)
tx ERROR: Error received from server: Only maintainers are allowed to update the source file.

Copy link
Contributor

@esbrandt esbrandt Aug 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I'm still not able to push template updates:

Try again, and sorry for the email spam. Transifex´ role management is nuts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@uklotzde
Copy link
Contributor

uklotzde commented Aug 7, 2019

LGTM

@uklotzde uklotzde merged commit 731893a into mixxxdj:2.2 Aug 7, 2019
@daschuer daschuer deleted the 2.2.2_trans branch September 26, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants