Qm shift key detection chroma #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
force-pushed
the
qm-shift
branch
2 times, most recently
from
ffb48d1
to
37460c0
Compare
|
It turns out that this has a rounding issue somewhere. A 440 Hz test is no in the center of one bin. |
daschuer
changed the title
daschuer
changed the title
|
OK, issues are fixed. |
|
Any plans for an upstream patch? |
uklotzde
reviewed
Aug 8, 2019
|
|
ready. |
|
LGTM. Hopefully we can drop our patches eventually with an upcoming qm-dsp update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the chroma starts at full key C3, the 1/3 key below is not used.
This may leads to a lower value for C3.
This is fixed here.