Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effect Blacklisting #1674

Merged
merged 20 commits into from
May 29, 2018
Merged

Effect Blacklisting #1674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
6d61872
Added hidden visibility mode for LV2 effects
kshitij98 May 19, 2018
9caa1f7
Blacklisted hidden effects from menu
kshitij98 May 19, 2018
02cf7dd
effectsmanager.cpp: Added visibility check
kshitij98 May 19, 2018
566db03
Integrated config and fixed blacklisting effects
kshitij98 May 20, 2018
036f0e2
Updated Effect Blacklisting Preferences
kshitij98 May 20, 2018
92acfe0
Shifted visibility logic to EffectsManager
kshitij98 May 23, 2018
94ff53a
pParent as the first argument convention
kshitij98 May 23, 2018
260bfcd
Added "Type" column in Available Effects List
kshitij98 May 23, 2018
72b1f91
Added support for Qt5 (setResizeMode/setSectionResizeMode)
kshitij98 May 24, 2018
eb992a3
Coding standards conformance
kshitij98 May 25, 2018
8caa6ab
Removed visibility settings from EffectsBackend
kshitij98 May 26, 2018
0aa3cf8
Merge branch 'lv2_support2' into effect_blacklisting
kshitij98 May 28, 2018
cd39efb
Renamed "Native" to "Built-in"
kshitij98 May 28, 2018
4e3468c
Merge branch 'effect_blacklisting' of https://github.com/kshitij98/mi…
kshitij98 May 28, 2018
b4efad1
Added BackendType enum
kshitij98 May 28, 2018
e250f10
Changed "BackendType" to "EffectBackendType"
kshitij98 May 28, 2018
5bbe893
Updated blacklisting comment
kshitij98 May 28, 2018
ff90165
Removed backendName QString from EffectManifest
kshitij98 May 29, 2018
b87b2bb
Created Backend specific visibility group
kshitij98 May 29, 2018
99bb100
Updated TestEffectBackend
kshitij98 May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 21 additions & 20 deletions build/depends.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,7 @@ def sources(self, build):
"preferences/broadcastsettings.cpp",
"preferences/broadcastsettings_legacy.cpp",
"preferences/broadcastsettingsmodel.cpp",
"preferences/effectsettingsmodel.cpp",
"preferences/broadcastprofile.cpp",
"preferences/upgrade.cpp",
"preferences/dlgpreferencepage.cpp",
Expand All @@ -769,26 +770,26 @@ def sources(self, build):
"effects/effectchainmanager.cpp",
"effects/effectsbackend.cpp",

"effects/native/nativebackend.cpp",
"effects/native/bitcrushereffect.cpp",
"effects/native/balanceeffect.cpp",
"effects/native/linkwitzriley8eqeffect.cpp",
"effects/native/bessel4lvmixeqeffect.cpp",
"effects/native/bessel8lvmixeqeffect.cpp",
"effects/native/threebandbiquadeqeffect.cpp",
"effects/native/biquadfullkilleqeffect.cpp",
"effects/native/loudnesscontoureffect.cpp",
"effects/native/graphiceqeffect.cpp",
"effects/native/parametriceqeffect.cpp",
"effects/native/flangereffect.cpp",
"effects/native/filtereffect.cpp",
"effects/native/moogladder4filtereffect.cpp",
"effects/native/reverbeffect.cpp",
"effects/native/echoeffect.cpp",
"effects/native/autopaneffect.cpp",
"effects/native/phasereffect.cpp",
"effects/native/metronomeeffect.cpp",
"effects/native/tremoloeffect.cpp",
"effects/builtin/builtinbackend.cpp",
"effects/builtin/bitcrushereffect.cpp",
"effects/builtin/balanceeffect.cpp",
"effects/builtin/linkwitzriley8eqeffect.cpp",
"effects/builtin/bessel4lvmixeqeffect.cpp",
"effects/builtin/bessel8lvmixeqeffect.cpp",
"effects/builtin/threebandbiquadeqeffect.cpp",
"effects/builtin/biquadfullkilleqeffect.cpp",
"effects/builtin/loudnesscontoureffect.cpp",
"effects/builtin/graphiceqeffect.cpp",
"effects/builtin/parametriceqeffect.cpp",
"effects/builtin/flangereffect.cpp",
"effects/builtin/filtereffect.cpp",
"effects/builtin/moogladder4filtereffect.cpp",
"effects/builtin/reverbeffect.cpp",
"effects/builtin/echoeffect.cpp",
"effects/builtin/autopaneffect.cpp",
"effects/builtin/phasereffect.cpp",
"effects/builtin/metronomeeffect.cpp",
"effects/builtin/tremoloeffect.cpp",

"engine/effects/engineeffectsmanager.cpp",
"engine/effects/engineeffectrack.cpp",
Expand Down
24 changes: 12 additions & 12 deletions src/broadcast/broadcastmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,13 @@ void BroadcastManager::slotControlEnabled(double v) {
bool atLeastOneEnabled = false;
QList<BroadcastProfilePtr> profiles = m_pBroadcastSettings->profiles();
for(BroadcastProfilePtr profile : profiles) {
if(profile->getEnabled()) {
if (profile->getEnabled()) {
atLeastOneEnabled = true;
break;
}
}

if(!atLeastOneEnabled) {
if (!atLeastOneEnabled) {
m_pBroadcastEnabled->set(false);
emit(broadcastEnabled(0.0));
QMessageBox::warning(nullptr, tr("Action failed"),
Expand All @@ -112,7 +112,7 @@ void BroadcastManager::slotControlEnabled(double v) {
m_pStatusCO->forceSet(STATUSCO_UNCONNECTED);
QList<BroadcastProfilePtr> profiles = m_pBroadcastSettings->profiles();
for(BroadcastProfilePtr profile : profiles) {
if(profile->connectionStatus() == BroadcastProfile::STATUS_FAILURE) {
if (profile->connectionStatus() == BroadcastProfile::STATUS_FAILURE) {
profile->setConnectionStatus(BroadcastProfile::STATUS_UNCONNECTED);
}
}
Expand All @@ -133,9 +133,9 @@ void BroadcastManager::slotProfilesChanged() {
QVector<NetworkOutputStreamWorkerPtr> workers = m_pNetworkStream->outputWorkers();
for(NetworkOutputStreamWorkerPtr pWorker : workers) {
ShoutConnectionPtr connection = qSharedPointerCast<ShoutConnection>(pWorker);
if(connection) {
if (connection) {
BroadcastProfilePtr profile = connection->profile();
if(profile->connectionStatus() == BroadcastProfile::STATUS_FAILURE
if (profile->connectionStatus() == BroadcastProfile::STATUS_FAILURE
&& !profile->getEnabled()) {
profile->setConnectionStatus(BroadcastProfile::STATUS_UNCONNECTED);
}
Expand All @@ -145,10 +145,10 @@ void BroadcastManager::slotProfilesChanged() {
}

bool BroadcastManager::addConnection(BroadcastProfilePtr profile) {
if(!profile)
if (!profile)
return false;

if(findConnectionForProfile(profile).isNull() == false) {
if (findConnectionForProfile(profile).isNull() == false) {
return false;
}

Expand All @@ -164,11 +164,11 @@ bool BroadcastManager::addConnection(BroadcastProfilePtr profile) {
}

bool BroadcastManager::removeConnection(BroadcastProfilePtr profile) {
if(!profile)
if (!profile)
return false;

ShoutConnectionPtr connection = findConnectionForProfile(profile);
if(connection) {
if (connection) {
disconnect(profile.data(), SIGNAL(connectionStatusChanged(int)),
this, SLOT(slotConnectionStatusChanged(int)));

Expand All @@ -188,10 +188,10 @@ ShoutConnectionPtr BroadcastManager::findConnectionForProfile(BroadcastProfilePt
QVector<NetworkOutputStreamWorkerPtr> workers = m_pNetworkStream->outputWorkers();
for(NetworkOutputStreamWorkerPtr pWorker : workers) {
ShoutConnectionPtr connection = qSharedPointerCast<ShoutConnection>(pWorker);
if(connection.isNull())
if (connection.isNull())
continue;

if(connection->profile() == profile) {
if (connection->profile() == profile) {
return connection;
}
}
Expand All @@ -207,7 +207,7 @@ void BroadcastManager::slotConnectionStatusChanged(int newState) {
// Collect status info
QList<BroadcastProfilePtr> profiles = m_pBroadcastSettings->profiles();
for (BroadcastProfilePtr profile : profiles) {
if(!profile->getEnabled()) {
if (!profile->getEnabled()) {
continue;
}
enabledCount++;
Expand Down
2 changes: 1 addition & 1 deletion src/effects/native/autopaneffect.cpp → src/effects/builtin/autopaneffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/autopaneffect.h"
#include "effects/builtin/autopaneffect.h"

#include <QtDebug>

Expand Down
0 src/effects/native/autopaneffect.h → src/effects/builtin/autopaneffect.h
View file
Open in desktop
File renamed without changes.
0 src/effects/native/balanceeffect.cpp → src/effects/builtin/balanceeffect.cpp
View file
Open in desktop
File renamed without changes.
0 src/effects/native/balanceeffect.h → src/effects/builtin/balanceeffect.h
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions src/effects/native/bessel4lvmixeqeffect.cpp → src/effects/builtin/bessel4lvmixeqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "effects/native/bessel4lvmixeqeffect.h"
#include "effects/builtin/bessel4lvmixeqeffect.h"

#include "effects/native/equalizer_util.h"
#include "effects/builtin/equalizer_util.h"
#include "util/math.h"

// static
Expand Down
2 changes: 1 addition & 1 deletion src/effects/native/bessel4lvmixeqeffect.h → src/effects/builtin/bessel4lvmixeqeffect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#include "control/controlproxy.h"
#include "effects/effect.h"
#include "effects/effectprocessor.h"
#include "effects/native/lvmixeqbase.h"
#include "effects/builtin/lvmixeqbase.h"
#include "engine/effects/engineeffect.h"
#include "engine/effects/engineeffectparameter.h"
#include "engine/enginefilterbessel4.h"
Expand Down
4 changes: 2 additions & 2 deletions src/effects/native/bessel8lvmixeqeffect.cpp → src/effects/builtin/bessel8lvmixeqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "effects/native/bessel8lvmixeqeffect.h"
#include "effects/builtin/bessel8lvmixeqeffect.h"

#include "effects/native/equalizer_util.h"
#include "effects/builtin/equalizer_util.h"
#include "util/math.h"

// static
Expand Down
2 changes: 1 addition & 1 deletion src/effects/native/bessel8lvmixeqeffect.h → src/effects/builtin/bessel8lvmixeqeffect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#ifndef BESSEL8LVMIXEQEFFECT_H
#define BESSEL8LVMIXEQEFFECT_H

#include "effects/native/lvmixeqbase.h"
#include "effects/builtin/lvmixeqbase.h"

#include <QMap>

Expand Down
4 changes: 2 additions & 2 deletions ...effects/native/biquadfullkilleqeffect.cpp → ...ffects/builtin/biquadfullkilleqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "effects/native/biquadfullkilleqeffect.h"
#include "effects/builtin/biquadfullkilleqeffect.h"

#include "effects/native/equalizer_util.h"
#include "effects/builtin/equalizer_util.h"
#include "util/math.h"

namespace {
Expand Down
2 changes: 1 addition & 1 deletion src/effects/native/biquadfullkilleqeffect.h → src/effects/builtin/biquadfullkilleqeffect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include "engine/effects/engineeffectparameter.h"
#include "engine/enginefilterbiquad1.h"
#include "engine/enginefilterbessel4.h"
#include "effects/native/lvmixeqbase.h"
#include "effects/builtin/lvmixeqbase.h"
#include "engine/enginefilterdelay.h"
#include "util/class.h"
#include "util/defs.h"
Expand Down
2 changes: 1 addition & 1 deletion src/effects/native/bitcrushereffect.cpp → src/effects/builtin/bitcrushereffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/bitcrushereffect.h"
#include "effects/builtin/bitcrushereffect.h"

#include "util/sample.h"

Expand Down
0 src/effects/native/bitcrushereffect.h → src/effects/builtin/bitcrushereffect.h
View file
Open in desktop
File renamed without changes.
59 changes: 59 additions & 0 deletions src/effects/builtin/builtinbackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@

#include <QtDebug>

#include "effects/builtin/builtinbackend.h"
#include "effects/builtin/flangereffect.h"
#include "effects/builtin/bitcrushereffect.h"
#include "effects/builtin/balanceeffect.h"
#include "effects/builtin/linkwitzriley8eqeffect.h"
#include "effects/builtin/bessel8lvmixeqeffect.h"
#include "effects/builtin/bessel4lvmixeqeffect.h"
#include "effects/builtin/threebandbiquadeqeffect.h"
#include "effects/builtin/biquadfullkilleqeffect.h"
#include "effects/builtin/graphiceqeffect.h"
#include "effects/builtin/parametriceqeffect.h"
#include "effects/builtin/filtereffect.h"
#include "effects/builtin/moogladder4filtereffect.h"
#ifndef __MACAPPSTORE__
#include "effects/builtin/reverbeffect.h"
#endif
#include "effects/builtin/echoeffect.h"
#include "effects/builtin/autopaneffect.h"
#include "effects/builtin/phasereffect.h"
#include "effects/builtin/loudnesscontoureffect.h"
#include "effects/builtin/metronomeeffect.h"
#include "effects/builtin/tremoloeffect.h"

BuiltInBackend::BuiltInBackend(QObject* pParent)
: EffectsBackend(pParent, EffectBackendType::BuiltIn) {
// Keep this list in a reasonable order
// Mixing EQs
registerEffect<Bessel4LVMixEQEffect>();
registerEffect<Bessel8LVMixEQEffect>();
registerEffect<LinkwitzRiley8EQEffect>();
registerEffect<ThreeBandBiquadEQEffect>();
registerEffect<BiquadFullKillEQEffect>();
// Compensations EQs
registerEffect<GraphicEQEffect>();
registerEffect<ParametricEQEffect>();
registerEffect<LoudnessContourEffect>();
// Fading Effects
registerEffect<FilterEffect>();
registerEffect<MoogLadder4FilterEffect>();
registerEffect<BitCrusherEffect>();
registerEffect<BalanceEffect>();
// Fancy effects
registerEffect<FlangerEffect>();
registerEffect<EchoEffect>();
registerEffect<AutoPanEffect>();
#ifndef __MACAPPSTORE__
registerEffect<ReverbEffect>();
#endif
registerEffect<PhaserEffect>();
registerEffect<MetronomeEffect>();
registerEffect<TremoloEffect>();
}

BuiltInBackend::~BuiltInBackend() {
//qDebug() << debugString() << "destroyed";
}
19 changes: 19 additions & 0 deletions src/effects/builtin/builtinbackend.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#ifndef BUILTINBACKEND_H
#define BUILTINBACKEND_H

#include "effects/defs.h"
#include "effects/effectsbackend.h"

class BuiltInBackend : public EffectsBackend {
Q_OBJECT
public:
BuiltInBackend(QObject* pParent);
virtual ~BuiltInBackend();

private:
QString debugString() const {
return "BuiltInBackend";
}
};

#endif /* BUILTINBACKEND_H */
2 changes: 1 addition & 1 deletion src/effects/native/echoeffect.cpp → src/effects/builtin/echoeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/echoeffect.h"
#include "effects/builtin/echoeffect.h"

#include <QtDebug>

Expand Down
0 src/effects/native/echoeffect.h → src/effects/builtin/echoeffect.h
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions src/effects/native/equalizer_util.h → src/effects/builtin/equalizer_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#ifndef EFFECTS_NATIVE_EQUALIZER_UTIL_H
#define EFFECTS_NATIVE_EQUALIZER_UTIL_H
#ifndef EFFECTS_BUILTIN_EQUALIZER_UTIL_H
#define EFFECTS_BUILTIN_EQUALIZER_UTIL_H

#include <QObject>

Expand Down Expand Up @@ -94,4 +94,4 @@ class EqualizerUtil {
};


#endif /* EFFECTS_NATIVE_EQUALIZER_UTIL_H */
#endif /* EFFECTS_BUILTIN_EQUALIZER_UTIL_H */
2 changes: 1 addition & 1 deletion src/effects/native/filtereffect.cpp → src/effects/builtin/filtereffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/filtereffect.h"
#include "effects/builtin/filtereffect.h"
#include "util/math.h"

namespace {
Expand Down
0 src/effects/native/filtereffect.h → src/effects/builtin/filtereffect.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/effects/native/flangereffect.cpp → src/effects/builtin/flangereffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/flangereffect.h"
#include "effects/builtin/flangereffect.h"

#include <QtDebug>

Expand Down
0 src/effects/native/flangereffect.h → src/effects/builtin/flangereffect.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/effects/native/graphiceqeffect.cpp → src/effects/builtin/graphiceqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/graphiceqeffect.h"
#include "effects/builtin/graphiceqeffect.h"
#include "util/math.h"

#define Q 1.2247449
Expand Down
0 src/effects/native/graphiceqeffect.h → src/effects/builtin/graphiceqeffect.h
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...effects/native/linkwitzriley8eqeffect.cpp → ...ffects/builtin/linkwitzriley8eqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "effects/native/linkwitzriley8eqeffect.h"
#include "effects/builtin/linkwitzriley8eqeffect.h"

#include "effects/native/equalizer_util.h"
#include "effects/builtin/equalizer_util.h"
#include "util/math.h"

static const unsigned int kStartupSamplerate = 44100;
Expand Down
0 src/effects/native/linkwitzriley8eqeffect.h → src/effects/builtin/linkwitzriley8eqeffect.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/effects/native/loudnesscontoureffect.cpp → ...effects/builtin/loudnesscontoureffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/loudnesscontoureffect.h"
#include "effects/builtin/loudnesscontoureffect.h"
#include "util/math.h"

namespace {
Expand Down
0 src/effects/native/loudnesscontoureffect.h → src/effects/builtin/loudnesscontoureffect.h
View file
Open in desktop
File renamed without changes.
0 src/effects/native/lvmixeqbase.h → src/effects/builtin/lvmixeqbase.h
View file
Open in desktop
File renamed without changes.
0 src/effects/native/metronomeclick.h → src/effects/builtin/metronomeclick.h
View file
Open in desktop
File renamed without changes.
0 src/effects/native/metronomeeffect.cpp → src/effects/builtin/metronomeeffect.cpp
View file
Open in desktop
File renamed without changes.
0 src/effects/native/metronomeeffect.h → src/effects/builtin/metronomeeffect.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ffects/native/moogladder4filtereffect.cpp → ...fects/builtin/moogladder4filtereffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/moogladder4filtereffect.h"
#include "effects/builtin/moogladder4filtereffect.h"
#include "util/math.h"


Expand Down
0 src/effects/native/moogladder4filtereffect.h → ...effects/builtin/moogladder4filtereffect.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/effects/native/parametriceqeffect.cpp → src/effects/builtin/parametriceqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/parametriceqeffect.h"
#include "effects/builtin/parametriceqeffect.h"
#include "util/math.h"

namespace {
Expand Down
0 src/effects/native/parametriceqeffect.h → src/effects/builtin/parametriceqeffect.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/effects/native/phasereffect.cpp → src/effects/builtin/phasereffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/phasereffect.h"
#include "effects/builtin/phasereffect.h"

#include <QDebug>

Expand Down
0 src/effects/native/phasereffect.h → src/effects/builtin/phasereffect.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/effects/native/reverbeffect.cpp → src/effects/builtin/reverbeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/reverbeffect.h"
#include "effects/builtin/reverbeffect.h"

#include <QtDebug>

Expand Down
0 src/effects/native/reverbeffect.h → src/effects/builtin/reverbeffect.h
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...ffects/native/threebandbiquadeqeffect.cpp → ...fects/builtin/threebandbiquadeqeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "effects/native/threebandbiquadeqeffect.h"
#include "effects/builtin/threebandbiquadeqeffect.h"

#include "effects/native/equalizer_util.h"
#include "effects/builtin/equalizer_util.h"
#include "util/math.h"

namespace {
Expand Down
0 src/effects/native/threebandbiquadeqeffect.h → ...effects/builtin/threebandbiquadeqeffect.h
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/effects/native/tremoloeffect.cpp → src/effects/builtin/tremoloeffect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include "effects/native/tremoloeffect.h"
#include "effects/builtin/tremoloeffect.h"

namespace {
// Used to avoid gain discontinuities when changing parameters too fast
Expand Down
0 src/effects/native/tremoloeffect.h → src/effects/builtin/tremoloeffect.h
View file
Open in desktop
File renamed without changes.
6 changes: 6 additions & 0 deletions src/effects/defs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ enum class EffectEnableState {
Enabling
};

enum class EffectBackendType {
BuiltIn,
LV2,
Unknown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this Unknown value? Can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added Unknown to handle the case of a manifest not having a backend rather than handling it while setting the effectType in dlgprefeffects. I think we should keep it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would an EffectManifest ever not have a backend?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EffectManifest would always have a backend currently. But because the backendName is not set in its constructor but through setBackendName() function, I think we should set it to Unknown for the time being rather than setting it to the first value (Built-in) in the EffectBackendType enum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought of a use case for this Unknown value. When we parse an XML file specifying an effect chain preset and use the EffectManifest::backendTypeFromString function, we can use the Unknown return value to determine that the effect cannot be loaded.

};

enum class SignalProcessingStage {
Prefader,
Postfader
Expand Down
Loading