fix crash enabling PFL after deleting EffectState while PFL is disabled #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be-ing
force-pushed
the
effect_debugging
branch
from
6703b8d to
1ab3cb6
Compare
Be-ing
force-pushed
the
effect_debugging
branch
from
1ab3cb6 to
0e728c0
Compare
|
Ping. Can we prioritize this critical bug fix? |
uklotzde
reviewed
Jan 7, 2018
src/effects/defs.h
Outdated
| // NOTE: Setting this to true will enable string manipulation and calls to | ||
| // qDebug() in the audio engine thread. That may cause audio dropouts, so only | ||
| // enable this when debugging the effects system. | ||
| const bool kEffectDebugOutput = false; |
There was a problem hiding this comment.
A constexpr might be more suitable to enforce evaluation (and optimization) at compile time
|
The crash is fixed, but replaced by another minor bug: When re-routing the deck to the effect unit with the effect still activated, it is not applied. You need to deactivate and activate the effect once, before it gets applied again. |
EngineEffectChain should be responsible for managing routing switch states, not EngineEffect.
|
LGTM. Just waiting for the builds to finish. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing https://bugs.launchpad.net/mixxx/+bug/1741213