Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slip waveformrenderer using rendergraph #14191

Merged
merged 3 commits into from
Jan 19, 2025
Merged

Conversation

m0dB
Copy link
Contributor

@m0dB m0dB commented Jan 18, 2025

Ports the slip waveformrenderer to a rendergraph node. This can be reviewed and merged independently from the PRs for the other waveformrenderers.

Copy link
Member

@acolombier acolombier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little warning due to type conversion and it's good to go!

Copy link
Member

@acolombier acolombier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks! Just waiting for CI to pass and I will merge it

@acolombier acolombier merged commit 0b88889 into mixxxdj:main Jan 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants