Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RekordBoxFeature: add played functionality to rekordbox external library #13834

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreivn2
Copy link

Hello,

Because I use mixxx a lot for my DVS setup with rekordbox exports from different sources I decided to create this PR.

This PR introduces minimal and simple changes to the RekordboxFeature in order to display and correctly interpret the "played" column in the external library view.

All SQL modified is in regards to tables that are dropped and created with each restart of mixxx.
Changes are integrated with the current hierarchy of QAbstractDisplayTable.

@JoergAtGithub
Copy link
Member

Welcome at Mixxx!
As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

@andreivn2
Copy link
Author

Welcome at Mixxx! As a first-time contributor we need you to sign the Mixxx Contributor Agreement and comment here when you have done so. It gives us permission to distribute your contribution under the GPL v2 or later license and the Apple Mac App Store. It is also helpful for us to have contact information for contributors in case we may need it in the future.

Done

@JoergAtGithub
Copy link
Member

The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system, as described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking
Than it will fix these issues automatically before every commit.
Alternatively, you can download the pre-commit.patch file from the artifacts of this PR
grafik
unzip it, and apply it using:
git apply pre-commit.patch

@andreivn2
Copy link
Author

Applied pre-commit patch now.

I tried to do it before creating the PR, but had some issues with it failing with some python exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants