History: show track count and duration in sidebar #12811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
force-pushed
the
history-count-duration
branch
from
65c355b
to
ad37b6a
Compare
github-actions
bot
added
skins
effects
engine
ui
build
autodj
code quality
preferences
scanner
waveform
vinylcontrol
soundsource
sync
broadcast
ronso0
force-pushed
the
history-count-duration
branch
from
ad37b6a
to
a065e4b
Compare
ronso0
added
history
and removed
broadcast
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exactly like in Playlists.
I thought it would be possible to avoid the code duplication (PlaylistFeature::createPlaylistLabels() and move this to a shared base method, but that wouldn't simplify the situation since History also needs the 'year created' in addition to an id/label pair.
Closes #12788