Sandbox: Fix regression that caused Sandbox::canAccess to fail
#12457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a regression introduced in 5111af7 and the corresponding issues (mixxxdj#11552 and mixxxdj#12137). To prevent this from happening again, 8c6154e marks `openSecurityToken` as `[[nodiscard]]`.
|
Doesn't the compiler optimize this unused variable away? |
I think not. We also use RAII and there the unused variable is not optimized away either. But in any case we should probably mark the token with |
daschuer
requested changes
Dec 22, 2023
|
I think we have no issue with the variable being unused. It is a QSharedPointer which has a scope until the end of the function. |
Co-authored-by: Daniel Schürmann <[email protected]>
fwcd
force-pushed
the
fix-sandbox-access-2.4
branch
from
a74a637 to
a9f55c9
Compare
Swiftb0y
approved these changes
Dec 22, 2023
uklotzde
reviewed
Dec 22, 2023
fwcd
changed the title
Sandbox::canAccess to always failSandbox::canAccess to fail
daschuer
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12137 (and #11552)
This fixes a regression with macOS sandboxing introduced in #3761 that caused
Sandbox::canAccessto always fail and to wrongly present this dialog on every launch:The issue was that the token is not assigned to a variable and thus immediately deinitialized (and invalidated):
See #3761 (comment) for details. To avoid regressing on this in the future, I have added a
[[nodiscard]]to theopenSecurityTokenmethods, which will generate a warning if used like this again.