WTrackProperty mouse click actions

[Be-ing]

This will allow the removal of the eject button from skins. Together with making the spinny toggling a global rather than per-deck state, a whole column can be removed from the grid of buttons next to the overview waveforms. That will feel less cluttered and allow more width for the overviews.

[Be-ing]

Hmm, actually I think ejecting should only be done on middle click. Right clicking should bring up a context menu.

[Be-ing]

Hmm, actually I think ejecting should only be done on middle click. Right clicking should bring up a context menu.

However, I do not think this should hold up merging this PR. After #1197 is merged I can take care of cleaning up the track context menu and bringing it up on right click of WTrackProperty in one PR.

[daschuer]

I think this is not a good replacement for the eject button in the skins.

Personally, actually I will not miss the eject button at all. But if one need it for his use case he will not find it, if it is accessible at all. I have no idea how to access the middle click from my laptop mouse-pad. This issue becomes worse if we think about touch access.

A deck context menu with an eject button will work for me.
Isn't this a good first menu entry for such a menu?

[Be-ing]

Personally, actually I will not miss the eject button at all. But if one need it for his use case he will not find it, if it is accessible at all. I have no idea how to access the middle click from my laptop mouse-pad. This issue becomes worse if we think about touch access.

The is no need for a way to eject tracks. The only difference between ejecting a track then loading a new one versus just loading a new one is clearing the GUI for a short time. I do not know about Windows or Mac, but on GNU/Linux a three finger tap on a touchpad typically acts as middle click. For touch screens, I do not know, but again, it's not really a necessary functionality.

A deck context menu with an eject button will work for me.
Isn't this a good first menu entry for such a menu?

That is a good idea.

[JosepMaJAZ]

A rather good reason to use the eject button on Windows is so that the file is freed and other programs can access it in write mode. Think about the preview deck, for example. Or think about using the 4 deck mode but only using the third or fourth deck for a few songs.
With no eject button, you need to load other tracks there.
Also, Mixxx does some track data saving when the track pointer is freed. If it stays loaded, it will not be freed, until the program is closed.

And yes, sometimes, it might also be a visual distraction.

[Be-ing]

IMO none of those are important enough to require taking space on screen with a button. I think being hidden in a right click menu and/or middle click action is sufficient.

[JosepMaJAZ]

//ironic mode//Are you designing a skin for the Nokia 3310?///ironic mode/

I am looking at the Deere skin (as well as Latenight) and I cannot understand what I will gain by using a single line of buttons where the eject and vinyl buttons are. Either you're talking about a completely different skin, making the buttons twice as big or making the waveform sumary twice as SMALL.
And then, you also say that this is more important than the eject feature.

[Be-ing]

I am looking at the Deere skin (as well as Latenight) and I cannot understand what I will gain by using a single line of buttons where the eject and vinyl buttons are.

The issue isn't really the width of a column of buttons, although it is nice to free some space. The issue is the spinny toggle button being in each deck, which should be a global skin option that affects all decks. After removing that button, another one in the grid must be removed to keep an even number of buttons.

[radusuciu]

Right click > middle click for options imo.

[Be-ing]

I found a reason to bring back the eject button, so I'm closing this for now. It would still be nice to have a right click context menu after #1197 is merged.