Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix horizontal drawing of wvumetergl #10979

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix horizontal drawing of wvumetergl #10979

merged 1 commit into from
Oct 18, 2022

Conversation

m0dB
Copy link
Contributor

@m0dB m0dB commented Oct 18, 2022

No description provided.

@m0dB
Copy link
Contributor Author

m0dB commented Oct 18, 2022

@ronso0 do you want me to create a pull request for main as well? And how about your fix? Shall I create a 2.3 pull request for that or will you do that yourself?

@ronso0
Copy link
Member

ronso0 commented Oct 18, 2022

Yep, that fixes it, thank you!

#10978 is only a workaround for the transparency issue, and since #4906 went into main it's only needed there.
It reduces the yellow (Classsic: red) background to a colored border and now that I see it I think that's sufficient to get attention.
It's better that way regardless if you find a fix for the root cause.

@ronso0
Copy link
Member

ronso0 commented Oct 18, 2022

(waiting for green lights, than we can merge)

@ronso0
Copy link
Member

ronso0 commented Oct 18, 2022

@m0dB
btw I'd appreciate a soonish review of #10973

@ronso0 ronso0 merged commit 867e9e4 into mixxxdj:2.3 Oct 18, 2022
napaalm added a commit to napaalm/mixxx that referenced this pull request Mar 23, 2023
This reverts commit 867e9e4, reversing
changes made to 363b49b.
napaalm added a commit to napaalm/mixxx that referenced this pull request Mar 23, 2023
This reverts commit 867e9e4, reversing
changes made to 363b49b.
napaalm added a commit to napaalm/mixxx that referenced this pull request Mar 24, 2023
This reverts commit 867e9e4, reversing
changes made to 363b49b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants