Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Policy CMP0099 and CMP0111 #10896

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Set Policy CMP0099 and CMP0111 #10896

merged 1 commit into from
Sep 14, 2022

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Sep 13, 2022 •
edited
Loading

There is an issue on Ubuntu 22.4 issue in #10881
This change will help to be informed early.

CMP0099 is already set in main and is backported to 2.3 here.

@github-actions github-actions bot added the build label Sep 13, 2022
@daschuer daschuer mentioned this pull request Sep 14, 2022
Closed
@daschuer
Copy link
Member Author

Looking at the build output if this one merged to main #10898 it does what it aims to do, fail early with a reasonable error Message:

CMake Error in CMakeLists.txt:
  IMPORTED_LOCATION not set for imported target "qt5keychain" configuration
  "RelWithDebInfo".

So this one is ready to merge!

@daschuer daschuer added this to the 2.3.4 milestone Sep 14, 2022
@Holzhaus Holzhaus merged commit 749d61d into mixxxdj:2.3 Sep 14, 2022
@Holzhaus
Copy link
Member

Thanks

@daschuer daschuer deleted the cmp0111 branch October 12, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@daschuer @Holzhaus