Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numark DJ2Go2: support HotCue clear with Pad #10841

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Numark DJ2Go2: support HotCue clear with Pad #10841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 144 additions & 0 deletions res/controllers/Numark_DJ2GO2_Touch.midi.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,78 @@
<script-binding/>
</options>
</control>
<control>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DJ2GO2/DJ2GO2 Touch does not support "shift" button, but send another control (control + 8) when push "Pad" holding "PAD MODE" in "CUES" mode.
Other DJ software assigns it to clear hotcue.
In other modes, holding "PAD MODE" is ignored. DJ2GO2/DJ2GO2 Touch sends same control holding "PAD MODE" or not.

<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.hotcueButtons[1].input</key>
<status>0x84</status>
<midino>0x09</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.hotcueButtons[1].input</key>
<status>0x94</status>
<midino>0x09</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.hotcueButtons[2].input</key>
<status>0x84</status>
<midino>0x0A</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.hotcueButtons[2].input</key>
<status>0x94</status>
<midino>0x0A</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.hotcueButtons[3].input</key>
<status>0x84</status>
<midino>0x0B</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.hotcueButtons[3].input</key>
<status>0x94</status>
<midino>0x0B</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.hotcueButtons[4].input</key>
<status>0x84</status>
<midino>0x0C</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.hotcueButtons[4].input</key>
<status>0x94</status>
<midino>0x0C</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel1]</group>
<key>DJ2GO2Touch.leftDeck.loopIn.input</key>
Expand Down Expand Up @@ -572,6 +644,78 @@
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.hotcueButtons[1].input</key>
<status>0x85</status>
<midino>0x09</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.hotcueButtons[1].input</key>
<status>0x95</status>
<midino>0x09</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.hotcueButtons[2].input</key>
<status>0x85</status>
<midino>0x0A</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.hotcueButtons[2].input</key>
<status>0x95</status>
<midino>0x0A</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.hotcueButtons[3].input</key>
<status>0x85</status>
<midino>0x0B</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.hotcueButtons[3].input</key>
<status>0x95</status>
<midino>0x0B</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.hotcueButtons[4].input</key>
<status>0x85</status>
<midino>0x0C</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.hotcueButtons[4].input</key>
<status>0x95</status>
<midino>0x0C</midino>
<options>
<script-binding/>
</options>
</control>
<control>
<group>[Channel2]</group>
<key>DJ2GO2Touch.rightDeck.loopIn.input</key>
Expand Down
15 changes: 14 additions & 1 deletion res/controllers/Numark_DJ2GO2_Touch_scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,20 @@ DJ2GO2Touch.Deck = function(deckNumbers, midiChannel) {
this.hotcueButtons[i] = new components.HotcueButton({
group: "[Channel" + script.deckFromGroup(this.currentDeck) + "]",
midi: [0x94 + midiChannel, 0x00 + i],
number: i
number: i,
input: function(channel, control, value, _status, _group) {
// DJ2GO2/DJ2GO2 Touch does not have a "shift" button,
// but when in CUES Pad Mode, holding the PAD MODE button will
// cause the controller to send messages where the originating midi
// control is offset by 8.
// this "feature" only applies to the CUES PAD MODE. Holding the button
// in other modes does nothing.
if (control <= 8) {
Swiftb0y marked this conversation as resolved.
Show resolved Hide resolved
engine.setValue(this.group, "hotcue_" + this.number + "_activate", value);
} else {
engine.setValue(this.group, "hotcue_" + this.number + "_clear", value);
}
},
});
var sampler = i + (midiChannel * DJ2GO2Touch.padsPerDeck);
this.samplerButtons[i] = new components.SamplerButton({
Expand Down