Change Android mixpanel default properties ($app_release, $app_build_number) from number to string #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…number) from number to string iOS's $app_build_number is in string with XX.XX.XX format, and Android sdk sends number. Although Mixpanel is designed to handle mixed types, unfortunately it's not free. our query engine needs to slow down when it encounters different types. especially for Mixpanel default properties, this impacts most of our clients. this PR matche the types of two defualt properties with iOS expecting overall performance improvements for properties query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS's $app_build_number is string with XX.XX.XX format, and Android sdk sends number.
Although Mixpanel is designed to handle mixed types, unfortunately it's not free. our query engine needs to slow down when it encounters different types. especially for Mixpanel default properties, this impacts most of our clients. this PR matches the types of two default properties with iOS expecting overall performance improvements for properties query.