-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adborroto/PG 62 convert to typescript #23
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c01408e
feat(test): convert test to jest
adborroto 49161b8
feat: convert to typescript
adborroto 4262cb5
refactor: update readme
adborroto eeaaee6
refactor: remove unused ava libraries
adborroto 8974554
fix: update ci
adborroto 229dd7f
feat: add nvmrc
adborroto ce17305
fix: remove private packages deps
adborroto 692918f
fix: fix eslint
adborroto 1c898bd
fix: fix jest config
adborroto eddde60
refactor: remove babel
adborroto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
{ | ||
"extends": ["mixmax/node", "mixmax/prettier"] | ||
"extends": [ | ||
"mixmax/node", | ||
"mixmax/prettier" | ||
], | ||
"sourceType": "module" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
name: continuous-integration | ||
'on': | ||
push: | ||
branches: | ||
- alpha | ||
- beta | ||
- master | ||
pull_request: | ||
branches: | ||
- master | ||
jobs: | ||
default: | ||
uses: mixmaxhq/github-workflows/.github/workflows/npm_module.yml@main | ||
with: | ||
coverage_threshold: 40 | ||
secrets: inherit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,4 +24,4 @@ node_modules | |
.node_repl_history | ||
.DS_Store | ||
*.sublime-workspace | ||
/dist | ||
/dist |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
const jestCoverageConfig = require('@mixmaxhq/jest-coverage-config/typescript'); | ||
const jestJunitConfig = process.env.CI && require('@mixmaxhq/jest-junit-config'); | ||
|
||
module.exports = { | ||
clearMocks: true, | ||
...jestJunitConfig, | ||
...jestCoverageConfig, | ||
collectCoverageFrom: ['src/**/*.[tj]s', '!src/**/*.fixtures.[tj]s', '!**/src/**/*.test.[tj]s'], | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update this? Or remove it altogether, if we'll be maintaining a CHANGELOG file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should yes. But I don't know how to publish this package. Should I do it manually ?
@bradvogel do you know?, last release was 5y ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, the old school way :-/. This repo doesn't have semantic-release that auto-publishes.
You should be able to run
mixmax dev npm publish
(instructions here) which runs this script.