Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsors design KO #222

Open
mpetitdant opened this issue Mar 14, 2014 · 3 comments
Open

Sponsors design KO #222

mpetitdant opened this issue Mar 14, 2014 · 3 comments
Milestone

Comments

@mpetitdant
Copy link

Should be :
gold : 2 sponsors per line
silver : 3/line
bronze : 4/line

mpetitdant added a commit to mpetitdant/linkit that referenced this issue Mar 14, 2014
@mpetitdant
Copy link
Author

Not sure my fix is better. Main issue seems to be the logo sizes inconsistency ... we should enforce a logo size per sponsoring level

@clacote
Copy link

clacote commented Mar 14, 2014

I didn't test your PR, but for responsive design: no fixed sizes, especially for images.

I already spent a lot of time on those sponsor columns.

On Sat, Mar 15, 2014 at 12:29 AM, Mathieu Petitdant
[email protected] wrote:

Not sure my fix is better. Main issue seems to be the logo sizes inconsistency ... we should enforce a logo size per sponsoring level

Reply to this email directly or view it on GitHub:
#222 (comment)

@cexbrayat
Copy link

Maybe we should do simpler with one silver per line?
Le 15 mars 2014 00:32, "Cyril Lacôte" [email protected] a écrit :

I didn't test your PR, but for responsive design: no fixed sizes,
especially for images.

I already spent a lot of time on those sponsor columns.

On Sat, Mar 15, 2014 at 12:29 AM, Mathieu Petitdant
[email protected] wrote:

Not sure my fix is better. Main issue seems to be the logo sizes

inconsistency ... we should enforce a logo size per sponsoring level

Reply to this email directly or view it on GitHub:
#222 (comment)

Reply to this email directly or view it on GitHubhttps://github.com//issues/222#issuecomment-37707691
.

@mpetitdant mpetitdant added this to the ASAP milestone Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants