Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS SwiftUI Testbed example #302

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

jranson
Copy link
Contributor

@jranson jranson commented Dec 20, 2020

this PR adds a full swift/swiftui version of the testbed example project

@jranson
Copy link
Contributor Author

jranson commented Jan 5, 2021

@armadsen just wanted to check in on this PR and make sure it is useful to the project. thanks!

@armadsen
Copy link
Member

armadsen commented Jan 5, 2021

Hi James, yes, this is wonderful. Thank you so much. I need to review in some depth before I merge, but I haven't forgotten, just busy. I'll let you know when/if I have feedback.

@armadsen armadsen self-assigned this Jan 5, 2021
@armadsen armadsen added this to the 1.8 milestone Jan 5, 2021
@jranson
Copy link
Contributor Author

jranson commented Jan 5, 2021

Great, thanks! As this is my first swift contribution ever (i'm a go developer), I definitely welcome all feedback and critiques. I learned a lot and appreciate this project very much.

@jranson
Copy link
Contributor Author

jranson commented May 2, 2022

While I appreciate this project, it is clear at this point that it has been abandoned.

@jranson jranson closed this May 2, 2022
@latenitefilms
Copy link

@jranson - Definitely not abandoned as @armadsen made changes to the master branch on 22nd February, I'd say he's just really busy, and unfortunately this pull request hasn't been a priority. My suggestion would be to keep this pull request open, because even if it's haven't been merged yet - it's still REALLY helpful for those that stumble across this repo.

@armadsen
Copy link
Member

armadsen commented May 2, 2022 via email

@armadsen armadsen reopened this Jun 17, 2022
@armadsen armadsen merged commit f02a217 into mixedinkey-opensource:master Jun 17, 2022
@armadsen armadsen changed the title add macos swift testbed example Add macOS SwiftUI Testbed example Jun 17, 2022
@armadsen
Copy link
Member

Finally got to reviewing this. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants