-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macOS SwiftUI Testbed example #302
Add macOS SwiftUI Testbed example #302
Conversation
@armadsen just wanted to check in on this PR and make sure it is useful to the project. thanks! |
Hi James, yes, this is wonderful. Thank you so much. I need to review in some depth before I merge, but I haven't forgotten, just busy. I'll let you know when/if I have feedback. |
Great, thanks! As this is my first swift contribution ever (i'm a go developer), I definitely welcome all feedback and critiques. I learned a lot and appreciate this project very much. |
While I appreciate this project, it is clear at this point that it has been abandoned. |
@jranson - Definitely not abandoned as @armadsen made changes to the master branch on 22nd February, I'd say he's just really busy, and unfortunately this pull request hasn't been a priority. My suggestion would be to keep this pull request open, because even if it's haven't been merged yet - it's still REALLY helpful for those that stumble across this repo. |
I certainly can’t prove it, but this PR actually crossed my mind yesterday (I’ve been writing more SwiftUI myself lately).
The project is not abandoned. As Chris said, I’m just really busy, and this is necessarily a free-time project. That said, I’m sorry I let this PR sit so long and will go back through it in the next couple days.
…-Andrew
On May 1, 2022, at 11:38 PM, Chris Hocking ***@***.***> wrote:
@jranson - Definitely not abandoned as @armadsen made changes to the master branch on 22nd February, I'd say he's just really busy, and unfortunately this pull request hasn't been a priority. My suggestion would be to keep this pull request open, because even if it's haven't been merged yet - it's still REALLY helpful for those that stumble across this repo.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
Finally got to reviewing this. Thank you so much! |
this PR adds a full swift/swiftui version of the testbed example project