Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve available devices after app did become active #210

Merged
merged 3 commits into from
Oct 27, 2017

Conversation

VNKorchagin
Copy link

…ion)

* Retrieve available devices after app did become active now
@armadsen
Copy link
Member

Thanks for the pull request!

MIKMIDI supports both macOS and iOS, and the changes you've made will break building for macOS. Can you please conditionalize the code as well as the dependency on UIKit?

@armadsen armadsen self-assigned this Oct 26, 2017
@armadsen armadsen added the bug label Oct 26, 2017
@VNKorchagin
Copy link
Author

Sorry, yes, it's my fault. I've never written a program for both systems (macOS and iOS).

I selected the code sections that require UIKIT by macros __IPHONE_OS_VERSION_MAX_ALLOWED. Compatibility with Mac OS has been restored now

@armadsen
Copy link
Member

Thanks for making that change. I think using #if TARGET_OS_IPHONE is the better way to go, as that is specifically intended for doing conditional use of iOS API. You can find examples in several MIKMIDI source files, including NSUIApplication+MIKMIDI.h.

@VNKorchagin
Copy link
Author

Yes you are right.
I made changes in accordance with the existing project code style.

Thanks for your feedback

@armadsen armadsen merged commit 6dcb616 into mixedinkey-opensource:master Oct 27, 2017
@armadsen
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants