-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements MIKMIDIConnectionManager (Issue #106) #115
Conversation
… MIKMIDISourceEndpoint.
…g connected devices.
… initial connection behavior.
…es] actually returned an NSSet.
…tedToDevice: actually work now.
…ered the saved configuration during loading.
…nplugging virtual MIDI device.
…n disconnection to MIKMIDIConnectionManager.
… disconnected upon calling -[MIKMIDIConfigurationManager loadConfiguration].
I love your work. Will test this out over weekend. Thanks |
It looks great to me. The only thing I don't necessarily like is that the saved configurations rely on the class name not ever changing. I think simply exposing -userDefaultsConfigurationKey for subclasses to be able to override would be sufficient for resolving that though. |
Actually, I should have read my own code ;). |
…ager initWithName:delegate:eventHandler:].
Okay, I missed that too :) That was my only concern, and since that was a non-issue, I'd say I give the pull request a 👍🏻 |
…tion on application backgrounding/termination.
Implements MIKMIDIConnectionManager (Issue #106)
@cflesner and @johndpope I'd very much appreciate your feedback on this before I merge it. The major relevant API is in https://github.com/mixedinkey-opensource/MIKMIDI/blob/Issue106/Source/MIKMIDIConnectionManager.h
Implements Issue #106.