Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIKMIDI should use nullability annotations #39

Closed
kris2point0 opened this issue Feb 16, 2015 · 2 comments
Closed

MIKMIDI should use nullability annotations #39

kris2point0 opened this issue Feb 16, 2015 · 2 comments
Assignees
@armadsen
Labels
enhancement
Milestone
1.5

Comments

@kris2point0
Copy link
Contributor

The nullability annotations added to Objective-C with the introduction of Swift 1.2 should be added to MIKMIDI.
@armadsen
Copy link
Member

Chris Lattner indicated that Apple will likely provide a new macro, something like, NS_ASSUME_NONNULL_BEGIN/END, so it might be worth waiting for that.

This thread has good info:
http://lists.apple.com/archives/xcode-users/2015/Feb/msg00046.html

@armadsen armadsen modified the milestone: 1.2 Jul 6, 2015
@armadsen armadsen self-assigned this Nov 4, 2015
@armadsen armadsen modified the milestones: 1.1, 1.2 Nov 4, 2015
armadsen pushed a commit that referenced this issue Nov 4, 2015
Issue #39 & #108: Moved conditional macros for nullability and generi…
c72f864 
…cs into new MIKMIDICompilerCompatibility.h header.
armadsen pushed a commit that referenced this issue Nov 4, 2015
Issue #39 & #108: Added nullability and more generics annotations to …
e5ecc2d 
…MIKMIDIDeviceManager.
armadsen pushed a commit that referenced this issue Nov 4, 2015
Issue #39 & #108: Added nullability and more generics annotations to …
ef212c6 
…MIKMIDIInputPort.
armadsen pushed a commit that referenced this issue Nov 6, 2015
Issue #39: Added nullability annotations to MIKMIDIDevice.
5f2001e
armadsen pushed a commit that referenced this issue Nov 6, 2015
Issue #39: Added nullability annotations to MIKMIDIUtilities.
6f5a524
armadsen pushed a commit that referenced this issue Nov 10, 2015
Issue #39: Added nullability annotations to remaining code.
d12cdf8
armadsen pushed a commit that referenced this issue Nov 11, 2015
Issue #39 & #108: Fixed up some nullability and generics annotations.
7b25b18
armadsen pushed a commit that referenced this issue Nov 11, 2015
Issue #39: Another minor nullability fix.
396fc0a
@armadsen
Copy link
Member

This should be complete now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armadsen armadsen

Labels
enhancement
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@armadsen @kris2point0