Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain cycle between MIKMIDISequence and MIKMIDISequencer #205

Closed
rrc2soft opened this issue Jun 27, 2017 · 1 comment
Closed

Retain cycle between MIKMIDISequence and MIKMIDISequencer #205

rrc2soft opened this issue Jun 27, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@rrc2soft
Copy link

As mentioned in the bug title, there is a retain cycle between those two classes. Therefore, if an instance of MIKMIDISequencer is set to nil, such instance will never call dealloc, as its 'sequence' property has a strong reference to it.

MIKMIDISequence.h:
@property (nonatomic, readonly, nullable) MIKMIDISequencer *sequencer;

MIKMIDISequence.m:
@interface MIKMIDISequence () { MIKMIDISequencer *_sequencer; }

MIKMIDISequencer.h
@property (nonatomic, strong) MIKMIDISequence *sequence;

@armadsen armadsen self-assigned this Aug 19, 2017
@armadsen armadsen added the bug label Aug 20, 2017
@armadsen armadsen added this to the 1.6.2 milestone Aug 20, 2017
@armadsen
Copy link
Member

Fixed in master now, and will be in the 1.6.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants