Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MIKMIDIInputPort API #109

Closed
armadsen opened this issue Nov 4, 2015 · 1 comment
Closed

Improve MIKMIDIInputPort API #109

armadsen opened this issue Nov 4, 2015 · 1 comment
Assignees
@armadsen
Labels
enhancement
Milestone
1.5

Comments

@armadsen
Copy link
Member

armadsen commented Nov 4, 2015

Note that this is not a public facing API, but will have implications for improvements to public facing API in MIKMIDIDeviceManager.

In particular, right now, both MIKMIDIInputPort and MIKMIDIDeviceManager have logic for handling multiple connected sources. Effort there is duplicated and wasted. This is primarily because MIKMIDIInputPort's API has no provision for per-source event handlers.
@armadsen armadsen self-assigned this Nov 4, 2015
@armadsen armadsen added this to the 1.1 milestone Nov 4, 2015
armadsen pushed a commit that referenced this issue Nov 4, 2015
Issue #109: Refactored MIKMIDIInputPort and MIKMIDIDeviceManager. Sim…
f71e399 
…plifies public endpoint disconnection API.
armadsen pushed a commit that referenced this issue Nov 4, 2015
Issue #109: Fixed exception thrown when connecting to second (and sub…
68467f8 
…sequent) endpoints in MIKMIDIInputPort.
armadsen pushed a commit that referenced this issue Nov 4, 2015
Issue #109: Removed a little dead code in MIKMIDIInputPort.
bfbc326
armadsen added a commit that referenced this issue Nov 4, 2015
@armadsen
Merge pull request #111 from mixedinkey-opensource/Issue109
9054d33 
Issue #109: Refactor MIKMIDIInputPort.
@armadsen
Copy link
Member Author

I'm happy with this at this point. The enhancements made here were used to simplify and improve MIKMIDIDeviceManager and indirectly to ease implementation of MIKMIDIConnectionManager (#106).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armadsen armadsen

Labels
enhancement
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
1 participant
@armadsen