-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build to support macOS arm64/x86_64 #82
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated to fix failing tests due to actions/setup-python#696 |
It's working as expected. |
miute
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Update build to support macOS arm64/x86_64 * Tests to skip python 3.8, 3.9 for macos-14 runner * Add newline to end of build.yml
miute
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Update build to support macOS arm64/x86_64 * Tests to skip python 3.8, 3.9 for macos-14 runner * Add newline to end of build.yml
miute
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Update build to support macOS arm64/x86_64 * Tests to skip python 3.8, 3.9 for macos-14 runner * Add newline to end of build.yml
miute
added a commit
that referenced
this pull request
Apr 24, 2024
miute
pushed a commit
that referenced
this pull request
Apr 24, 2024
* Update build to support macOS arm64/x86_64 * Tests to skip python 3.8, 3.9 for macos-14 runner * Add newline to end of build.yml
"Co-authored-by" was removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #80. This is my first attempt at using cibuildwheel or github actions so forgive me if it has issues.
The main change is using os [macos-13, macos-14] to build the x86_64 and arm64 wheels on their respective systems.
Note that I had to remove cp37 for it to build and test successfully but there is probably a way to fix that.