Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add correct permissions for monitoring service and make its creation optional #42

Merged
merged 6 commits into from
Jul 28, 2021
Merged

Add correct permissions for monitoring service and make its creation optional #42

merged 6 commits into from
Jul 28, 2021

Conversation

YannikBramkamp
Copy link
Contributor

Closes #41

@mittwald-machine
Copy link
Collaborator

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

@martin-helmich
Copy link
Member

@YannikBramkamp This one is still marked as "Draft" and is getting stale by now. Is this ready for review, or does it still need some ❤️?

@YannikBramkamp
Copy link
Contributor Author

@YannikBramkamp This one is still marked as "Draft" and is getting stale by now. Is this ready for review, or does it still need some heart?

@martin-helmich I figured I'd wait for #38 to be merged, since I'll preobably have to make some changes to this pr.

@mittwald-machine
Copy link
Collaborator

There has not been any activity to this pull request in the last 30 days. It will automatically be closed after 7 more days. Remove the stale label to prevent this.

@YannikBramkamp YannikBramkamp marked this pull request as ready for review June 30, 2021 14:41
@YannikBramkamp
Copy link
Contributor Author

This should be ready now @martin-helmich

hensur
hensur requested changes Jul 2, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@YannikBramkamp YannikBramkamp merged commit fc4e64e into mittwald:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hensur hensur hensur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing permissions for creating services
4 participants
@YannikBramkamp @mittwald-machine @martin-helmich @hensur