Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maint/go mod and valid seperator #10

Merged
merged 12 commits into from
Apr 2, 2019

Conversation

Hermsi1337
Copy link
Member

@Hermsi1337 Hermsi1337 commented Mar 29, 2019

Changes:

  • Switched separator from "," to "." since "," is not a valid label value
    * Valid label values must be 63 characters or less and must be empty or begin and end with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between
  • Moved to go modules
  • Upgraded to go 1.12
  • Removed deprecated function calls
  • Add goreleaser for pushing images and building binary
  • Push to master will create and push the latest tag
  • stable- and versioned-tags will be deployed upon new tags in github

Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github cannot properly show the Files tab on my machine (probably too many files), so no inline comments:

  • Regarding the . separator: This is an annotation not a label. The usual restrictions for label values should not apply to annotation values. AFAIK, using a comma in here should work just as intended.
  • Regarding the Docker images: Do we really need a separate Docker tag containing the Go version with which the generator was built?

@Hermsi1337
Copy link
Member Author

Hermsi1337 commented Apr 2, 2019

Regarding the seperator:
zomfg, you're ight.. o.O
I could swear that kubernetes yelled errors at me for the values containing a ,... maybe solstice.

Regarding the tag:
I thought a tag containing the go-version is great for someone who builds his own image on top of the base kubernetes-secret-generator-image.

@martin-helmich martin-helmich merged commit 3da21d1 into master Apr 2, 2019
@martin-helmich martin-helmich deleted the maint/go-mod-and-valid-seperator branch April 2, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants