-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maint/go mod and valid seperator #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github cannot properly show the Files tab on my machine (probably too many files), so no inline comments:
- Regarding the
.
separator: This is an annotation not a label. The usual restrictions for label values should not apply to annotation values. AFAIK, using a comma in here should work just as intended. - Regarding the Docker images: Do we really need a separate Docker tag containing the Go version with which the generator was built?
Regarding the seperator: Regarding the tag: |
Changes:
*
Valid label values must be 63 characters or less and must be empty or begin and end with an alphanumeric character ([a-z0-9A-Z]) with dashes (-), underscores (_), dots (.), and alphanumerics between
goreleaser
for pushing images and building binarymaster
will create and push thelatest
tagstable
- and versioned-tags will be deployed upon new tags in github