generate password using base64

main.go

@@ -18,7 +18,11 @@
 package main
 
 import (
+	"crypto/rand"
+	"encoding/base64"
 	"flag"
+	"time"
+
 	"github.com/golang/glog"
 	"github.com/mittwald/kubernetes-secret-generator/util"
 	"k8s.io/client-go/kubernetes"
@@ -30,9 +34,6 @@ import (
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/cache"
 	"k8s.io/client-go/tools/clientcmd"
-	"crypto/rand"
-	"math/big"
-	"time"
 )
 
 const (
@@ -42,9 +43,6 @@ const (
 	SecretSecureAnnotation      = "secret-generator.v1.mittwald.de/secure"
 )
 
-var runes = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789")
-var runesLen = big.NewInt(int64(len(runes)))
-
 var namespace string
 var allNamespaces bool
 var kubecfg string
@@ -180,13 +178,8 @@ func (c *GeneratorController) SecretAdded(obj interface{}) {
 }
 
 func generateSecret(length int) (string, error) {
-	b := make([]rune, length)
-	for i := range b {
-		n, err := rand.Int(rand.Reader, runesLen)
-		if err != nil {
-			return "", err
-		}
-		b[i] = runes[n.Int64()]
-	}
-	return string(b), nil
+	b := make([]byte, length)
+	rand.Read(b)
+
+	return base64.StdEncoding.EncodeToString(b)[0:length], nil
 }