Consolidate onto INSTA_WORKSPACE_ROOT
#614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now a single place where `INSTA_WORKSPACE_ROOT` & `CARGO_MANIFEST_DIR` are checked, with priority to the former. Fixes mitsuhiko#575 Could do with an integration test
|
I'll merge now since it's just a refactor and there's a fairly complete test. This closes #575 insofar as I can't see how that issue exists in the proposed code. But I also can't see how it existed in the recent code, so I'm not confident it's fixed. If there's a reproducible failure, happy to get it working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to fix #575. Though after some iterations, it ends up being a code-clean-up. I'm not sure how
CARGO_MANIFEST_DIRis leaking through — it's only referenced byenv!rather thanenv::var, so should only matter at compile time.Added a pretty thorough integration test (albeit maybe a bit too complicated)