Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rerun date string format #55

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

timbrigham-oc
Copy link
Contributor

@timbrigham-oc timbrigham-oc commented Jun 7, 2024

The rerun date strings are using a US centric format, month / day / year, hour:minue:second AM/PM by utilizing the toLocaleString.

I propose the use of ISO 8601 strings, much easier to read, and results in the operations to be sorted in a much more logical fashion.

In the attached screenshot you can see that everything executed on 6/6 was in the afternoon, and sorts by date as anticipated.

For 6/7, the bottom couple entries aren't in chronological order. Addition of padding and removing AM/PM as done by ISO8601 should rectify this.

image

@timbrigham-oc
Copy link
Contributor Author

Screenshot showing the updated format -

image

@elegantmoose
Copy link
Collaborator

Fine with me.

@clenk , thoughts?

@clenk
Copy link
Collaborator

clenk commented Jul 1, 2024

I like the change and am good with merging it as-is, but what would you think of replacing the T in the middle with a space to be more human-readable?

@jbaptperez
Copy link
Contributor

@clenk, the T is required by ISO-8601 standard; it clearly indicates the time part of a date time string (as all date time components are optional in the standard).
Being ISO-8601 means any ISO-8601 compatible library can read this date time.

However, this is probably not the target here and using a space instead of a T could be more human readable.

@elegantmoose elegantmoose merged commit e0269b5 into mitre:master Jul 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants