fix affiliation chunking and git plugin performance #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
added
type: bug
j-lanson
requested review from
alilleybrinker,
patrickjcasey and
mchernicoff
For really large repos, affiliation might send a request to the git plugin containing all commits such that the request is larger than the gRPC maximum. The Hipcheck gRPC protocol currently does not allow for chunked queries, so the affiliation plugin has been modified to do its own chunking internally.
Although the git plugin's `RawCommit` struct contains author and committer information, the `Commit` struct does not. For looking up the contributors to a commit we were doing a lot of expensive and wasteful computation to re-engineer what is already available in `RawCommit`. This commit exposes more functionality to the query endpoint functions to get `RawCommit` collections so we spend less time looking for information that was already there before we discarded it.
j-lanson
force-pushed
the
jlanson/fix-chunking
branch
from
ecac8c9
to
d56ac61
Compare
mchernicoff
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #603 .
As I mentioned in the issue comment, the cause of @alilleybrinker's issue related to gRPC message side stems from large outbound requests from the affiliation plugin to the git plugin when analyzing large repositories like
torvalds/linux. The Hipcheck gRPC protocol does not support request chunking at present, only response chunking. Updated affiliation plugin to do some chunking of outbound requests of its own, until the time this issue is resolvedOnce I fixed that, I found that affiliation's requests to git were taking an extremely and unacceptably long time to execute, and found our way of getting contributor-commit information was extremely inefficient and could be improved by using
RawCommits instead ofCommit.