Skip to content

Commit

Permalink
Fix atomic planner tests
Browse files Browse the repository at this point in the history
Use assert_called_with (python/cpython#100690)
  • Loading branch information
clenk committed Feb 8, 2024
1 parent 33a972e commit 20decfa
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions tests/planners/test_atomic.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ class LinkStub():
def __init__(self, ability_id):
self.ability = AbilityStub(ability_id)

def __eq__(self, other):
return self.ability.ability_id == other.ability.ability_id


@pytest.fixture
def atomic_planner():
Expand All @@ -61,8 +64,8 @@ def test_atomic_with_links_in_order(self, event_loop, atomic_planner):

assert atomic_planner.operation.apply.call_count == 1
assert atomic_planner.operation.wait_for_links_completion.call_count == 1
assert atomic_planner.operation.apply.called_with(LinkStub('ability_b'))
assert atomic_planner.operation.wait_for_links_completion.called_with([LinkStub('ability_b')])
atomic_planner.operation.apply.assert_called_with(LinkStub('ability_b'))
atomic_planner.operation.wait_for_links_completion.assert_called_with([LinkStub('ability_b')])

def test_atomic_with_links_out_of_order(self, event_loop, atomic_planner):

Expand All @@ -77,8 +80,8 @@ def test_atomic_with_links_out_of_order(self, event_loop, atomic_planner):

assert atomic_planner.operation.apply.call_count == 1
assert atomic_planner.operation.wait_for_links_completion.call_count == 1
assert atomic_planner.operation.apply.called_with(LinkStub('ability_b'))
assert atomic_planner.operation.wait_for_links_completion.called_with([LinkStub('ability_b')])
atomic_planner.operation.apply.assert_called_with(LinkStub('ability_b'))
atomic_planner.operation.wait_for_links_completion.assert_called_with([LinkStub('ability_b')])

def test_atomic_no_links(self, event_loop, atomic_planner):

Expand Down

0 comments on commit 20decfa

Please sign in to comment.