Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoding of query parameters when forwarding requests #187

Merged
merged 5 commits into from
Mar 27, 2021
Merged

Fix encoding of query parameters when forwarding requests #187

merged 5 commits into from
Mar 27, 2021

Conversation

dani72
Copy link
Contributor

@dani72 dani72 commented Jan 11, 2021

No description provided.

@dsmiley
Copy link
Collaborator

dsmiley commented Jan 12, 2021

Thanks for reporting this bug and fixing it!
I'd rather preserve the test of the un-encoded values in some way, which still works with plain ProxyServlet. Can you try something there... perhaps having a separate test method for them or... I dunno.

You can also add this to CHANGES.md -- point out the problem is with URITemplateProxyServlet.

@dsmiley dsmiley added the bug label Jan 12, 2021
@dsmiley dsmiley mentioned this pull request Feb 24, 2021
Closed
@dsmiley dsmiley merged commit d753533 into mitre:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dani72 @dsmiley