Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encoded question marks in path are not encoded from proxy #190

Closed
fpetterlate opened this issue Feb 22, 2021 · 3 comments
Closed

Encoded question marks in path are not encoded from proxy #190

fpetterlate opened this issue Feb 22, 2021 · 3 comments
Assignees
@dsmiley
Labels
bug

Comments

@fpetterlate
Copy link

If I try to do a request on:

https://localhost:8084/proxy/api/pathwithquestionmark%3F%3F?from=1&to=10

I see in the log that I get:
proxy GET uri: /proxy/api/pathwithquestionmark%3F%3F -- https://my.server.com/api/pathwithquestionmark???from=1&to=10

So it looks like questions marks in path are not encoded anymore.
@dsmiley dsmiley self-assigned this Feb 23, 2021
@dsmiley dsmiley added the bug label Feb 23, 2021
dsmiley added a commit that referenced this issue Feb 23, 2021
@dsmiley
/%3F '?' should stay encoded in path (#190)
ee1f770
dsmiley added a commit that referenced this issue Feb 23, 2021
@dsmiley
/%3F '?' should stay encoded in path (#190) (#191)
cec23d3 
(question mark)
@dsmiley
Copy link
Collaborator

dsmiley commented Feb 23, 2021

Fixed! Thanks for reporting the problem!

@dsmiley dsmiley closed this as completed Feb 23, 2021
@fpetterlate
Copy link
Author

Thanks :) Will there be a release soon?

@dsmiley
Copy link
Collaborator

dsmiley commented Feb 24, 2021

I created #193 for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsmiley dsmiley

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dsmiley @fpetterlate