Release 0.3.3 #932
Merged
Release 0.3.3 #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes mitogen-hq#891 (cherry picked from commit 1a84184)
Co-authored-by: Stefano Rivera <[email protected]> When the requested module (e.g. ansible.module_utils.distro) - is provided by another module *e.g. distro) - that itself was a package (e.g. distro 1.7.0) At runtime - ansible/module_utils/distro/__init__.py executes - if https://pypi.org/project/distro/ is present, it's loaded as ansible.module_utils.distro - otherwise ansible/module_utils/distro/_distro.py is loaded ParentEnumerationMethod would wrongly use whatever was in sys.modules['ansible.module_utils.distro]. Instead we should ascend to the first parent that has fullname == sys.modules[fullname].__name__. Then descend to the appropriate .py file on disk. This bug didn't show up before because until distro 1.7.0 (Feb 2022) the top-level distro module was a module (distro.py) not a package (distro/__init__.py) fixes mitogen-hq#906
master.ParentEnumerationMethod: Require matching pkg.__name__
We don't wish to modify someone's local OS, or rely on them having sudo (with or without password).
Master and the 0.3.x branch have never supported these versions, but we didn't update the metadata.
Test and build improvements
unittest2 is incomplatible with Python 3.10
Python 3.10 support
assertEquals() is deperecated in unittest
Non-zero return codes should raise an exception, not pass silently.
Add Ansible podman connection support
Some modules additionally enable unicode_literals (which Ansible doesn't do). I've chosen not to change that, for now.
Cleanup imports in mitogen, ansible_mitogen, & tests
Co-authored-by: Rezart Qelibari <[email protected]> Replaces mitogen-hq#837 Fixes mitogen-hq#836
mitogen.utils: Preserve docstring of functions decorated @with_router
This reapplies an earlier change, when this plugin was first introduced to Mitogen. The plugin was updated to fix [DEPRECATION WARNING]: The '_remote_checksum()' method is deprecated. I've elected to short-circuit the if statemtn logic, rather than deleting/unindenting, to make the code delta much smaller. This should make it easier to maintain/update. Fixes mitogen-hq#915
Fix [DEPRECATION WARNING]: The '_remote_checksum()' method is deprecated.
- working for GitHub and similar Markdown engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.