Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible_mitogen: Fix "filedescriptor out of range in select()" in WorkerProcess #1065

Merged
merged 2 commits into from
May 2, 2024

Conversation

moreati
Copy link
Member

@moreati moreati commented Apr 18, 2024

This

  • Clarifies and corrects docstrings and comments based on investigation for ansible_mitogen: ValueError: filedescriptor out of range in select() #957
  • Removes unused Poller*._repr attributes
  • Introduces mitogen.parent.POLLERS & mitogen.parent.POLLER_LEIGHTWEIGHT
  • Switches ansible_mitogen.Poller to POLLER_LEIGHTWEIGHT, fixing "filedescriptor out of range in select()" in WorkerProcess
@@ -1,7 +1,7 @@
 SSH command size: 759
-Bootstrap (mitogen.core) size: 17862 (17.44KiB)
+Bootstrap (mitogen.core) size: 17899 (17.48KiB)

                               Original          Minimized           Compressed
-mitogen.parent            98171 95.9KiB  50569 49.4KiB 51.5%  12742 12.4KiB 13.0%
+mitogen.parent            96988 94.7KiB  49853 48.7KiB 51.4%  12708 12.4KiB 13.1%
 mitogen.fork               8436  8.2KiB   4130  4.0KiB 49.0%   1648  1.6KiB 19.5%
 mitogen.ssh               10892 10.6KiB   6952  6.8KiB 63.8%   2113  2.1KiB 19.4%

@moreati moreati force-pushed the issue957 branch 3 times, most recently from 83032f5 to 5053121 Compare April 18, 2024 23:07
moreati and others added 2 commits April 19, 2024 10:40
This
- Clarifies and corrects docstrings and comments based on investigation for mitogen-hq#957
- Removes unused `Poller*._repr` attributes
- Eliminates some uses of `getattr()`
- Introduces `mitogen.parent.POLLERS` & `mitogen.parent.POLLER_LIGHTWEIGHT`

Preamble size change
```
@@ -1,7 +1,7 @@
 SSH command size: 759
-Bootstrap (mitogen.core) size: 17862 (17.44KiB)
+Bootstrap (mitogen.core) size: 17934 (17.51KiB)

                               Original          Minimized           Compressed
-mitogen.parent            98171 95.9KiB  50569 49.4KiB 51.5%  12742 12.4KiB 13.0%
+mitogen.parent            96979 94.7KiB  49844 48.7KiB 51.4%  12697 12.4KiB 13.1%
 mitogen.fork               8436  8.2KiB   4130  4.0KiB 49.0%   1648  1.6KiB 19.5%
 mitogen.ssh               10892 10.6KiB   6952  6.8KiB 63.8%   2113  2.1KiB 19.4%
```
…kerProcess

`mitogen.parent.POLLER_LIGHTWEIGHT` will normally be `PollPoller`, falling
back to `EpollPoller`, `KqueuePoller`, or `Poller`.

Fixes mitogen-hq#957

Co-authored-by: Luca Berruti <[email protected]>
Co-authored-by: Philippe Kueck <[email protected]>
@moreati moreati marked this pull request as ready for review April 19, 2024 19:03
@moreati moreati changed the title mitogen: Refactor Poller classes and Latch.poller_class selection ansible_mitogen: Fix "filedescriptor out of range in select()" in WorkerProcess Apr 24, 2024
@moreati moreati merged commit 0f34e25 into mitogen-hq:master May 2, 2024
46 checks passed
@moreati moreati deleted the issue957 branch May 2, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant