Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate remote temp dir if it no longer exists #1062

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markafarrell
Copy link

Previously we do not check if self.good_temp_dir is actually good before using it.

If the path that self.good_temp_dir has been removed then we need to re-create it before trying to use that directory.

ansible_mitogen.target.is_good_temp_dir(self.good_temp_dir) ensure that that is the case.

Fixes #1061

@markafarrell markafarrell force-pushed the feature/handle-tempdir-not-existing branch from e045ad5 to cfb836c Compare April 12, 2024 06:16
@moreati
Copy link
Member

moreati commented Apr 21, 2024

Notes to myself

  • ansible_mitogen.target.is_good_temp_dir(path) has a misleading name. It doesn't just do checks on an existing dir, it attempts to create the path.

@moreati moreati changed the title Recreate temp dir if it no longer exists Recreate remote temp dir if it no longer exists May 19, 2024
@moreati moreati mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Play fails if temp directory is deleted mid-play
2 participants