Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitogen: Clarify blacklisted import error message #1013

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

mitogen: Clarify blacklisted import error message #1013

wants to merge 2 commits into from

Commits on Jul 30, 2023

  1. tests: Remove BlacklistTest stubs (covered by ImporterBlacklistTest)

    @moreati
    moreati committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    ecb9b65 View commit details
    Browse the repository at this point in the history

  2. mitogen: Clarify blacklisted import error message 

    Previous phrasing was misleading - it implied a given module was explicitly on
the blacklist, even if it was due to a restrictive whitelist and the blacklist
was empty.

Arguably the blacklist/whitelist semantics are themselves misleading. A
redesign is tempting.

See also mitogen-hq#1011, mitogen-hq#808
    @moreati
    moreati committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    be9adb5 View commit details
    Browse the repository at this point in the history