Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite plays with hosts: localhost are not run #1069

Closed
moreati opened this issue May 3, 2024 · 1 comment
Closed

Test suite plays with hosts: localhost are not run #1069

moreati opened this issue May 3, 2024 · 1 comment
Labels
affects-0.3 Issues related to 0.3.X Mitogen releases bug Code feature that hinders desired execution outcome ci Issues related to CI in either Travis or Azure

Comments

@moreati
Copy link
Member

moreati commented May 3, 2024

hosts: localhost is not being matched, so the test is skipped. This happens on vanilla Ansible runs as well, so appears to be a test suite bug rather than a Mitogen bug.

PLAY [regression/issue_655_wait_for_connection_error.yml] **********************
skipping: no hosts matched

mitogen/tests/ansible/regression/issue_655__wait_for_connection_error.yml

Lines 7 to 8 in 0f34e25

- name: regression/issue_655_wait_for_connection_error.yml
hosts: localhost

@moreati moreati added bug Code feature that hinders desired execution outcome ci Issues related to CI in either Travis or Azure affects-0.3 Issues related to 0.3.X Mitogen releases labels May 3, 2024
@moreati
Copy link
Member Author

moreati commented May 6, 2024

This is caused by the -l/--limit clause in

mitogen/.ci/localhost_ansible_tests.py

Lines 95 to 97 in 0f34e25

playbook = os.environ.get('PLAYBOOK', 'all.yml')
ci_lib.run('./run_ansible_playbook.py %s -l target %s',
playbook, ' '.join(sys.argv[1:]))

moreati added a commit to moreati/mitogen that referenced this issue May 6, 2024
@moreati
tests: Remove --limit when running Ansible localhost CI
acd28c0 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
moreati added a commit to moreati/mitogen that referenced this issue May 6, 2024
@moreati
tests: Remove --limit when running Ansible localhost CI
8a95c70 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
@moreati moreati mentioned this issue May 6, 2024
Merged
philfry pushed a commit to philfry/mitogen that referenced this issue May 7, 2024
@moreati @philfry
tests: Remove --limit when running Ansible localhost CI
ffdfb9c 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
moreati added a commit to moreati/mitogen that referenced this issue May 7, 2024
@moreati
tests: Remove --limit when running Ansible localhost CI
524ff9d 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
moreati added a commit to moreati/mitogen that referenced this issue May 8, 2024
@moreati
tests: Remove --limit when running Ansible localhost CI
4b048ca 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
philfry pushed a commit to philfry/mitogen that referenced this issue May 9, 2024
@moreati @philfry
tests: Remove --limit when running Ansible localhost CI
0a042e3 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
philfry pushed a commit to philfry/mitogen that referenced this issue May 10, 2024
@moreati @philfry
tests: Remove --limit when running Ansible localhost CI
60f8682 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
@moreati moreati closed this as completed May 12, 2024
moreati added a commit to moreati/mitogen that referenced this issue May 21, 2024
@moreati
tests: Remove --limit when running Ansible localhost CI
0fe741c 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
rjhesketh pushed a commit to bbc/mitogen that referenced this issue Jul 10, 2024
@moreati @rjhesketh
tests: Remove --limit when running Ansible localhost CI
8b099c2 
Some tests were being incorrectly excluded. Including those that use
`add_host`.
refs mitogen-hq#1066, mitogen-hq#1069
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-0.3 Issues related to 0.3.X Mitogen releases bug Code feature that hinders desired execution outcome ci Issues related to CI in either Travis or Azure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@moreati