Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1090 - Add Micromasters production, fix S3/IAM policy issues #1442

Merged
merged 1 commit into from
Apr 5, 2023
Merged

#1090 - Add Micromasters production, fix S3/IAM policy issues #1442

merged 1 commit into from
Apr 5, 2023

Conversation

feoh
Copy link
Contributor

@feoh feoh commented Apr 5, 2023

Description

Add properly configured Pulumi Production stack for MM, and fix the issue where an errant Principal: * and an unneeded S3 bucket policy were removed.

Motivation and Context

Necessary to finish migration of micromasters RDS project to production.

How Has This Been Tested?

Pulumi up in production, QA, RC. Browsed 'smoke test' URls QA and RC.

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improves on existing behavior)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. (Did you install and run the pre-commit hooks?)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Ardiea
Ardiea approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@Ardiea Ardiea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@feoh feoh merged commit e9e7d48 into main Apr 5, 2023
@feoh feoh deleted the add_micromasters_production branch April 5, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ardiea Ardiea Ardiea approved these changes

@blarghmatey blarghmatey blarghmatey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feoh @blarghmatey @Ardiea