Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition Micromasters from Heroku Managed Postgres to Pulumi Managed RDS #1380

Merged
merged 23 commits into from
Mar 9, 2023

Conversation

feoh
Copy link
Contributor

@feoh feoh commented Feb 28, 2023

Description

This pull request contains the necessary Pulumi code and documentation to migrate the micromasters project from Heroku hosted Postgres to Amazon AWS RDS.

Motivation and Context

This pull request fixes #1090 and enables the migration of Heroku hosted Postgres to AWS RDS under management by Pulumi.

This represents an ongoing cost savings as well as a decrease in operational burden since the current Heroku hosted DB is largely managed manually.

How Has This Been Tested?

As per @pdpinch I browsed the following URLs in my browser and ensured that each loaded properly including proper layout, images and textual information.

https://micromasters-ci.odl.mit.edu/
https://micromasters-ci.odl.mit.edu/dedp/
https://micromasters-ci.odl.mit.edu/scm/
https://micromasters-ci.odl.mit.edu/cms/
https://micromasters-ci.odl.mit.edu/admin/
https://micromasters-ci.odl.mit.edu/learners/
https://micromasters-ci.odl.mit.edu/dashboard/

I used equivalent links for QA/RC.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x] Enhancement (improves on existing behavior)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project. (Did you install and run the pre-commit hooks?)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@feoh feoh marked this pull request as ready for review February 28, 2023 22:15
@feoh feoh changed the title Cpatti micromasters pulumi Transition Micromasters from Heroku Managed Postgres to Pulumi Managed RDS Feb 28, 2023
Copy link
Member

@blarghmatey blarghmatey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! A couple of minor notes, but otherwise should be ready to go. It does look like some unrelated changes from main branch got included so it might be worth a rebase to clean up the diff.

@feoh feoh force-pushed the cpatti_micromasters_pulumi branch from 4af511b to 5946de5 Compare March 8, 2023 18:29
@feoh feoh merged commit 7a72c70 into main Mar 9, 2023
@feoh feoh deleted the cpatti_micromasters_pulumi branch March 9, 2023 15:12
@Ardiea
Copy link
Member

Ardiea commented Mar 9, 2023

🎉 💯 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIgrate Micromasters resources into management by Pulumi
5 participants