-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition Micromasters from Heroku Managed Postgres to Pulumi Managed RDS #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feoh
changed the title
Cpatti micromasters pulumi
Transition Micromasters from Heroku Managed Postgres to Pulumi Managed RDS
Feb 28, 2023
shaidar
reviewed
Mar 1, 2023
src/ol_infrastructure/applications/micromasters/Pulumi.applications.micromasters.CI.yaml
Outdated
Show resolved
Hide resolved
shaidar
reviewed
Mar 1, 2023
src/ol_infrastructure/substructure/vault/policies/github/software_engineer.hcl
Outdated
Show resolved
Hide resolved
shaidar
reviewed
Mar 1, 2023
src/ol_infrastructure/applications/micromasters/Pulumi.applications.micromasters.QA.yaml
Outdated
Show resolved
Hide resolved
shaidar
reviewed
Mar 1, 2023
shaidar
reviewed
Mar 7, 2023
blarghmatey
reviewed
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! A couple of minor notes, but otherwise should be ready to go. It does look like some unrelated changes from main
branch got included so it might be worth a rebase to clean up the diff.
src/ol_infrastructure/infrastructure/aws/network/Pulumi.infrastructure.aws.network.CI.yaml
Outdated
Show resolved
Hide resolved
This reverts commit 1bce4a3.
…grated to AWS RDS
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
feoh
force-pushed
the
cpatti_micromasters_pulumi
branch
from
March 8, 2023 18:29
4af511b
to
5946de5
Compare
blarghmatey
approved these changes
Mar 9, 2023
🎉 💯 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains the necessary Pulumi code and documentation to migrate the micromasters project from Heroku hosted Postgres to Amazon AWS RDS.
Motivation and Context
This pull request fixes #1090 and enables the migration of Heroku hosted Postgres to AWS RDS under management by Pulumi.
This represents an ongoing cost savings as well as a decrease in operational burden since the current Heroku hosted DB is largely managed manually.
How Has This Been Tested?
As per @pdpinch I browsed the following URLs in my browser and ensured that each loaded properly including proper layout, images and textual information.
https://micromasters-ci.odl.mit.edu/
https://micromasters-ci.odl.mit.edu/dedp/
https://micromasters-ci.odl.mit.edu/scm/
https://micromasters-ci.odl.mit.edu/cms/
https://micromasters-ci.odl.mit.edu/admin/
https://micromasters-ci.odl.mit.edu/learners/
https://micromasters-ci.odl.mit.edu/dashboard/
I used equivalent links for QA/RC.
Types of changes
Checklist: