Add an additional layer of retries to get a moira client beyond the default 3 for urllib #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing, moira issue has been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Potentially addresses https://github.com/mitodl/hq/issues/3810#issuecomment-2007305350
Description (What does it do?)
The current request to get a moira client will retry up to 3x (the urllib library default) before giving up. This PR adds an additional layer of retries, defaulting to 3 (3x3 = 9) which can be adjusted via a new setting (
MOIRA_RETRIES).How can this be tested?
Unit tests should pass. You would need current .env settings for
MIT_WS_CERTIFICATE_FILEandMIT_WS_PRIVATE_KEY_FILEto be able to connect to moira successfully but without that you should see repeated attempts to connect in the log.