Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(deps): update dependency sass to ~1.78.0" #3145

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mudassir-hafeez
Copy link
Contributor

@mudassir-hafeez mudassir-hafeez commented Sep 10, 2024

This reverts commit 11c7936.

What are the relevant tickets?

No ticket is created.

Description (What does it do?)

I've noticed some warnings on the xPro local environment, due to the auto-merged Renovate PR: #3131.

watch-1   | LOG from ./node_modules/sass-loader/dist/cjs.js sass-loader ./node_modules/css-loader/dist/cjs.js!./node_modules/postcss-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js!./static/scss/layout.scss
watch-1   | <w> Deprecation Passing percentage units to the global abs() function is deprecated.
watch-1   | <w> In the future, this will emit a CSS abs() function to be resolved by the browser.
watch-1   | <w> To preserve current behavior: math.abs(100%)
watch-1   | <w> To emit a CSS abs() now: abs(#{100%})
watch-1   | <w> More info: https://sass-lang.com/d/abs-percent
watch-1   | <w> 
watch-1   | <w> node_modules/bootstrap/scss/vendor/_rfs.scss 54:14             divide()
watch-1   | <w> node_modules/bootstrap/scss/mixins/_grid.scss 66:15            row-cols()
watch-1   | <w> node_modules/bootstrap/scss/mixins/_grid-framework.scss 43:13  @content
watch-1   | <w> node_modules/bootstrap/scss/mixins/_breakpoints.scss 65:5      media-breakpoint-up()
watch-1   | <w> node_modules/bootstrap/scss/mixins/_grid-framework.scss 32:5   make-grid-columns()
watch-1   | <w> node_modules/bootstrap/scss/_grid.scss 72:3                    @import
watch-1   | <w> node_modules/bootstrap/scss/bootstrap.scss 16:9                @import
watch-1   | <w> static/scss/layout.scss 6:9                                    root stylesheet
watch-1   | <w> 
watch-1   | <w> Deprecation Sass's behavior for declarations that appear after nested
watch-1   | <w> rules will be changing to match the behavior specified by CSS in an upcoming
watch-1   | <w> version. To keep the existing behavior, move the declaration above the nested
watch-1   | <w> rule. To opt into the new behavior, wrap the declaration in `& {}`.
watch-1   | <w> 
watch-1   | <w> More info: https://sass-lang.com/d/mixed-decls
watch-1   | <w> 
watch-1   | <w> node_modules/bootstrap/scss/_custom-forms.scss 415:5  @import
watch-1   | <w> node_modules/bootstrap/scss/bootstrap.scss 24:9       @import
watch-1   | <w> static/scss/layout.scss 6:9                           root stylesheet
watch-1   | <w> 
watch-1   | <w> Deprecation Sass's behavior for declarations that appear after nested
watch-1   | <w> rules will be changing to match the behavior specified by CSS in an upcoming
watch-1   | <w> version. To keep the existing behavior, move the declaration above the nested
watch-1   | <w> rule. To opt into the new behavior, wrap the declaration in `& {}`.
watch-1   | <w> 
watch-1   | <w> More info: https://sass-lang.com/d/mixed-decls
watch-1   | <w> 
watch-1   | <w> node_modules/bootstrap/scss/_custom-forms.scss 441:5  @import
watch-1   | <w> node_modules/bootstrap/scss/bootstrap.scss 24:9       @import
watch-1   | <w> static/scss/layout.scss 6:9                           root stylesheet
watch-1   | <w> 
watch-1   | <w> Deprecation Sass's behavior for declarations that appear after nested
watch-1   | <w> rules will be changing to match the behavior specified by CSS in an upcoming
watch-1   | <w> version. To keep the existing behavior, move the declaration above the nested
watch-1   | <w> rule. To opt into the new behavior, wrap the declaration in `& {}`.
watch-1   | <w> 
watch-1   | <w> More info: https://sass-lang.com/d/mixed-decls
watch-1   | <w> 
watch-1   | <w> node_modules/bootstrap/scss/_custom-forms.scss 470:5  @import
watch-1   | <w> node_modules/bootstrap/scss/bootstrap.scss 24:9       @import
watch-1   | <w> static/scss/layout.scss 6:9                           root stylesheet
watch-1   | <w> 
watch-1   | <w> Deprecation Sass's behavior for declarations that appear after nested
watch-1   | <w> rules will be changing to match the behavior specified by CSS in an upcoming
watch-1   | <w> version. To keep the existing behavior, move the declaration above the nested
watch-1   | <w> rule. To opt into the new behavior, wrap the declaration in `& {}`.
watch-1   | <w> 
watch-1   | <w> More info: https://sass-lang.com/d/mixed-decls
watch-1   | <w> 
watch-1   | <w> node_modules/bootstrap/scss/_navbar.scss 174:9             @content
watch-1   | <w> node_modules/bootstrap/scss/mixins/_breakpoints.scss 65:5  media-breakpoint-up()
watch-1   | <w> node_modules/bootstrap/scss/_navbar.scss 173:7             @import
watch-1   | <w> node_modules/bootstrap/scss/bootstrap.scss 26:9            @import
watch-1   | <w> static/scss/layout.scss 6:9                                root stylesheet
watch-1   | <w> 
watch-1   | <w> Deprecation Sass's behavior for declarations that appear after nested
watch-1   | <w> rules will be changing to match the behavior specified by CSS in an upcoming
watch-1   | <w> version. To keep the existing behavior, move the declaration above the nested
watch-1   | <w> rule. To opt into the new behavior, wrap the declaration in `& {}`.
watch-1   | <w> 
watch-1   | <w> More info: https://sass-lang.com/d/mixed-decls
watch-1   | <w> 
watch-1   | <w> node_modules/bootstrap/scss/_navbar.scss 175:9             @content
watch-1   | <w> node_modules/bootstrap/scss/mixins/_breakpoints.scss 65:5  media-breakpoint-up()
watch-1   | <w> node_modules/bootstrap/scss/_navbar.scss 173:7             @import
watch-1   | <w> node_modules/bootstrap/scss/bootstrap.scss 26:9            @import
watch-1   | <w> static/scss/layout.scss 6:9                                root stylesheet
watch-1   | <w> 
watch-1   | <w> 40 repetitive deprecation warnings omitted.
watch-1   | <w> 
watch-1   | <w> null
watch-1   | 
watch-1   | webpack 5.94.0 compiled successfully in 29370 ms

According to the comments in this link #3015 (comment), the issue is resolved only in Bootstrap v5.3.2 and beyond.
We need to revert this to avoid releasing it on RC until #3079 is merged.

Note: The Bootstrap dependency upgrade to v5 is still a work in progress, as per the label in this PR #3079.

Screenshots (if appropriate):

  • Desktop screenshots
  • Mobile width screenshots

How can this be tested?

  • Check out this branch and run docker-compose up. There should be no related warnings appearing.
  • Check that all main pages are working.

Additional Context

@mudassir-hafeez mudassir-hafeez merged commit 1af89fb into master Sep 10, 2024
7 checks passed
@mudassir-hafeez mudassir-hafeez deleted the mudassir/revert-sass-1.78.0 branch September 10, 2024 10:29
@odlbot odlbot mentioned this pull request Sep 18, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants