Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

returning all resource types for similar resources endpoint #1849

Merged
merged 1 commit into from
Nov 26, 2024
Merged

returning all resource types for similar resources endpoint #1849

merged 1 commit into from
Nov 26, 2024

Conversation

shanbady
Copy link
Contributor

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/6132

Description (What does it do?)

Fixes the similar resources endpoint so that it returns more than just courses

How can this be tested?

  1. checkout this branch
  2. load up resources locally. ensure you have a variety of resource types (videos, courses, podcasts etc)
  3. go to the search page, find a learning resource and open up the drawer. in the "similar resources" carousel you should see a mixture of resources types and not just courses.

@shanbady shanbady added the Needs Review An open Pull Request that is ready for review label Nov 22, 2024
@shanbady shanbady marked this pull request as ready for review November 22, 2024 20:08
@shanbady shanbady changed the title returnning all resource types for similar returning all resource types for similar resources endpoint Nov 22, 2024
@mbertrand mbertrand self-assigned this Nov 25, 2024
mbertrand
mbertrand approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mbertrand mbertrand added Waiting on author and removed Needs Review An open Pull Request that is ready for review labels Nov 25, 2024
@shanbady shanbady merged commit 269f58e into main Nov 26, 2024
11 checks passed
@shanbady shanbady deleted the shanbady/similar-resources-only-returns-courses branch November 26, 2024 15:22
@odlbot odlbot mentioned this pull request Nov 26, 2024
Closed
2 tasks
mbertrand pushed a commit that referenced this pull request Dec 2, 2024
@shanbady @mbertrand
returnning all resource types for similar (#1849)
c20ed6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbertrand mbertrand mbertrand approved these changes

Assignees

@mbertrand mbertrand

Labels
Waiting on author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanbady @mbertrand