New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move facets first in tab order #1751

Draft

ChristopherChudzicki wants to merge 1 commit into main from cc/search-tab-order

Contributor

ChristopherChudzicki commented Oct 25, 2024

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5419

Description (What does it do?)

Puts facets after search results in tab order (and DOM order)

How can this be tested?

There should be no visual change.
Tab though the search page—either at /search or on the channel pages. Starting from the search text field, you should see:
1. Text field
2. Tabs (All | Courses | Programs) *Only the active tab is tabable. The other tabs are navigated to via arrow keys.)
3. Sort dropdown
4. Search results x 20 (or whatever)
5. THEN facets

Note: This change makes the facets a bit harder to get to, but the search results themselves are easier to get to.

Facets are still—somewhat—easily navigated to with a screenreader via the "Search FIlters" heading.


          move facets first in tab order

295062e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet