Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spinner for dashboard #646

Merged
merged 1 commit into from
Jun 29, 2016
Merged

Added spinner for dashboard #646

merged 1 commit into from
Jun 29, 2016

Conversation

noisecapella
Copy link
Contributor

What are the relevant tickets?

Fixes #587

What's this PR do?

Adds a spinner to the dashboard page when it is loading, and moved some dashboard tests from App_test.js into new DashboardPage_test.js

Where should the reviewer start?

How should this be manually tested?

View the dashboard over a slow connection. To simulate a slow connection replace the function in api.js with this:

export function getDashboard() {
  return new Promise(resolve => {
    setTimeout(() => {
      resolve(mockableFetchJSONWithCSRF('/api/v0/dashboard/', {}, true));
    }, 3000);
  });
}

Screenshots (if appropriate)

screenshot from 2016-06-27 15-23-09

@bdero bdero temporarily deployed to micromasters-ci-pr-646 June 27, 2016 19:23 Inactive
@giocalitri giocalitri self-assigned this Jun 27, 2016
});
});

});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty line at the end of the file

@giocalitri
Copy link
Contributor

small comment but looks good

@giocalitri
Copy link
Contributor

👍

@pdpinch
Copy link
Member

pdpinch commented Jun 27, 2016

We should get in the habit of consulting with Rob on things like this. I'm going to tag him on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard is missing a spinner
4 participants