Added text to JumboTron for terms of service #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giocalitri
added
Work in Progress
Waiting on Author
and removed
Needs Review
Work in Progress
labels
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes #633
What's this PR do?
Shows the same text on the terms of service page that we show on the profile page.
How should this be manually tested?
Create a new user on edX, login to MicroMasters with it and view the terms of service page. It should have the 'Welcome username, let's complete...' text. Note: it's important to have a brand new user to make sure that we handle the empty preferred name case correctly.
Screenshots (if appropriate)