Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes #620
What's this PR do?
Moves the react-mdl CSS back into dashboard.js. It overrides many common style rules which is why we're seeing different styles with it included. We're only using bootstrap CSS on the 404 page currently so this shouldn't cause any problems.
How should this be manually tested?
First, turn on DEBUG mode so we can view the 404 page. You can do this by setting
DEBUG=False
insettings.py
and adding your host name to theALLOWED_HOSTS
list.Then run
NODE_ENV=production ./webpack_if_prod.sh
in your terminal to generate static assets. Next, rundocker-compose run web ./manage.py collectstatic
to copy static assets intostaticfiles/
.After that, look at the two screenshots for the program page in #620. Go to a program page and verify that it looks like it did before, more or less. Go to
/xyz/
and verify the 404 page still works as expected, and also click the dropdown and click 'logout' to make sure that works.