-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated documentation to reflect edX changes #570
Conversation
- **Redirect uris**: The URL where MicroMaster’s will be running, followed by "/complete/edxorg/". | ||
If you're running it via Docker, run ``docker-machine ip`` from the host machine to get the | ||
container IP. MicroMaster’s runs on port ``8079`` by default, so this value should be something | ||
like ``http://192.168.99.100:8079/complete/edxorg/`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this IP is only correct if you're on a Mac and using docker-machine?
@aliceriot @noisecapella do you use localhost for the redirect uri?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use http://localhost:8079/complete/edxorg/ for the redirect uri on micromasters.d.
A couple of questions. Only the first one needs to be answered in these docs, I think. |
929939b
to
4527a3c
Compare
@pdpinch ready to review again. i shoe-horned in an addition to .gitignore. we never check in the |
like ``http://192.168.99.100:8079/complete/edxorg/`` | ||
**Linux users:** the MicroMaster’s URL will be `localhost:8079`. **OSX users:** In a terminal window on the | ||
host machine where the proper Docker environment has been set up (`eval "$(docker-machine env mm)"`), the | ||
MicroMaster's IP can be found by running ``docker-machine ip`` from the host machine. MicroMaster’s runs on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to specify the name of the machine, so it is docker-machine ip <machine_name>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still do not see the <machine_name> (or whatever you want to use)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed again :)
👍 |
e2268c3
to
97af64b
Compare
97af64b
to
e3f9bc0
Compare
What are the relevant tickets?
Closes #450
What's this PR do?
Updates our README to reflect updated edX docs, the new auth process, and a couple other minor details
How should this be manually tested?
If you feel particularly enterprising, you can run through the entire README to confirm the accuracy of these instructions