Added custom 404 error page #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context={ | ||
| "style_src": get_bundle_url(request, "style.js"), | ||
| "dashboard_src": get_bundle_url(request, "dashboard.js"), | ||
| "js_settings_json": json.dumps(js_settings), | ||
| } | ||
| ) | ||
|
|
||
|
|
||
| def handler404(request): |
There was a problem hiding this comment.
I feel like handler_404 and page_404 would be more PEP8 compliant, not sure how that treats numbers though
There was a problem hiding this comment.
I cannot change the name of handler404: this is the standard way to override the django default one.
There was a problem hiding this comment.
I will change the other one though
|
Looks great 👍 |
giocalitri
force-pushed
the
gdm_404_error
branch
from
abfed02
to
3d8ae15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
closes #440
What's this PR do?
Adds a custom 404 page
Where should the reviewer start?
probably
ui.viewsand then '404.html'How should this be manually tested?
to see the the 404 template, just go to
/404/.To actually test that a 404 is returned for a not existing URL, you need to:
docker-compose.ymlnode node_modules/webpack/bin/webpack.js --config webpack.config.prod.js --bailto build the static assetsdocker-compose run web ./manage.py collectstaticAny background context you want to provide?
This story does not address the case the page is not found in the react router
What GIF best describes this PR or how it makes you feel?