Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spinner positioning #563

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Fixed spinner positioning #563

merged 1 commit into from
Jun 20, 2016

Conversation

noisecapella
Copy link
Contributor

What are the relevant tickets?

Fixes #465

What's this PR do?

Sets the container div for the loader to use relative positioning so the inner spinner will be centered within that, rather than centered inside the entire page.

How should this be manually tested?

In api.js replace getUserProfile with this:

export function getUserProfile(username) {
  return new Promise(resolve => {
    setTimeout(() => {
      resolve(mockableFetchJSONWithCSRF(`/api/v0/profiles/${username}/`));
    }, 100000);
  });
}

This will delay the load of the user page for 100 seconds. Go to /users/ and see that the spinner is where it should be. You should be able to resize the browser without affecting the position of the spinner.

Screenshots (if appropriate)

screenshot from 2016-06-16 14-30-00

@bdero bdero temporarily deployed to micromasters-ci-pr-563 June 16, 2016 18:31 Inactive
@gsidebo gsidebo assigned gsidebo and unassigned gsidebo Jun 16, 2016
@gsidebo
Copy link
Contributor

gsidebo commented Jun 16, 2016

do we care about EOF linebreaks? everything looks good here other than that possible comment

@gsidebo
Copy link
Contributor

gsidebo commented Jun 16, 2016

👍

@alicewriteswrongs
Copy link
Contributor

@gsidebo it seems like we don't in general. I dislike seeing the little 🚫 symbol, but ¯_(ツ)_/¯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] user page: spinner appears below footer
4 participants