Removed apostrophe from MicroMaster's #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ class Footer extends React.Component { | |||
| <div className="container container-footer"> | |||
| <div className="row"> | |||
| <div className="col-md-8"> | |||
| <img src="/static/images/[email protected]" alt="MicroMaster’s" /> | |||
| <img src="/static/images/[email protected]" alt="MicroMasters" /> | |||
There was a problem hiding this comment.
Seems like this alt tag should actually be "MIT"
|
a couple of small things, but otherwise looks good |
|
whoops, didn't realize this was still in progress |
|
It's just in progress so we could discuss the questions in the linked issue. Did you have any feedback on those questions? |
noisecapella
force-pushed
the
gs/remove_apostrophe
branch
from
d8b0f74
to
f8b2ebd
Compare
| <p> | ||
| Use your edX.org account to enroll in a MicroMaster’s program and share your grades and progress with MIT. When you complete all the requirements and earn a MicroMaster’s credential, you can use it to apply for a Masters degree at MIT. | ||
| Use your edX.org account to enroll in a MicroMasters program and share your grades and progress with MIT. When you complete all the requirements and earn a MicroMaster’s credential, you can use it to apply for a Masters degree at MIT. |
There was a problem hiding this comment.
is the second MicroMaster's here retaining an apostrophe intentionally?
|
few questions, looked like there's a merge conflict as well. |
noisecapella
force-pushed
the
gs/remove_apostrophe
branch
from
9626e09
to
7c34c2d
Compare
|
Ok, all comments should be addressed |
|
👍 |
🎊 🎆 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Fixes #557
What's this PR do?
Removes apostrophe from MicroMaster's to become MicroMasters. Some apostrophes are left if they make sense in context
How should this be manually tested?
Grep through the code base to make sure all existing uses are updated, if relevant to the context