Dashboard: Adding "You passed this course" message with no certificates #5310
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #5310 +/- ##
==========================================
+ Coverage 93.61% 97.72% +4.11%
==========================================
Files 499 299 -200
Lines 22975 13979 -8996
Branches 966 0 -966
==========================================
- Hits 21508 13661 -7847
+ Misses 1360 318 -1042
+ Partials 107 0 -107
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| if (!course.certificate_url && course.is_passed) { | ||
| messages.push({ | ||
| message: "You passed this course." | ||
| }) |
There was a problem hiding this comment.
I think there might be a problem with this If I'm assuming correctly.
I had a passed course (Analog Learning 300) in a program for which i also didn't have a certificate and i saw Course passed message along with a Passed badge this is how the dashboard looked:
After shifting to this PR, and adding FinalGrade record for another course i see the dashboard like below, where I don't see Course Passed message for Analog Learning 300 but i see Passed badge where as i see Course Passed message for Analog Learning 100 but no Passed badge. I think we need to make some tweaks in https://github.com/mitodl/micromasters/blob/master/static/js/lib/grades.js#L55 as well?
There was a problem hiding this comment.
I did try reproducing your scenario, but I did see the message. So I think what is happening is that the Course Run for which you have a passing grade doen't have the status set: FinalGrade.objects.filter(user=self.user, status=FinalGradeStatus.COMPLETE)
There was a problem hiding this comment.
I think I might have messed up my data locally, if you are seeing the message and thePassed badge with this scenario it's fine then.
Pre-Flight checklist
What are the relevant tickets?
N/a
What's this PR do?
Update course status messages to show the message "You passed the course." for recent DEDP courses that that don't have a certificate.
How should this be manually tested?
Create a passing FinalGrade for a course run that has a start date after September 1st, 2022.
In the learner dashboard it should show a message the user passed the course.